Skip to content

parser_csv: skip empty or unparseable lines #5355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Watson1978 wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −0
Open

parser_csv: skip empty or unparseable lines #5355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/fluent/plugin/parser_csv.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ def configure(conf)

def parse(text, &block)
values = CSV.parse_line(text, col_sep: @delimiter)
unless values
yield nil, nil
return
end

r = Hash[@keys.zip(values)]
time, record = convert_values(parse_time(r), r)
yield time, record
Expand Down
8 changes: 8 additions & 0 deletions test/plugin/test_parser_csv.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,14 @@ def test_parse_with_option_delimiter(param)
end
end

def test_parse_empty_line
d = create_driver('keys' => '["k1","k2","k3"]')
d.instance.parse("") do |time, record|
assert_nil time
assert_nil record
end
end

sub_test_case 'parser' do
data('normal' => 'normal',
'fast' => 'fast')
Expand Down
Loading