Repository navigation
refactor(iam): drop the hand-routed scopes from the vendored routes - #9160
Conversation
S3 was the one credential scope rest-routes.json listed as hand-routed, authorized by the registry's rules alone, and #9155 moved it onto its generated routes. The list is empty, so its machinery goes: regen_rest_routes.py no longer writes handRouted or a hand-routed scope's required members, IamRestRoutes reads every model, regen_iam_authorized_actions.py takes every model's scope as routed, and the coverage test builds requests from what a route requires alone.
PR Summary by QodoRemove obsolete hand-routed IAM scope handling
AI Description
Merge Risk
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
Summary
S3 was the one credential scope
rest-routes.jsonlisted as hand-routed, authorized by the registry's rules alone. #9155 moved it onto its generated routes, so the list is empty, and this removes the machinery around it. Nothing an IAM check gives changes.regen_rest_routes.py: noHAND_ROUTED, nohandRoutedsection in the file, and norequiredmembers for a hand-routed scope's routes. Therequiresconditions of shared routes stay.rest-routes.json: loses its emptyhandRoutedsection.IamRestRoutes: reads every model, and fails to load only when the file has no models.regen_iam_authorized_actions.py: every model's scope is routed (routed_namespaces,route_methods).IamRestRoutesTest's denial-status conflict test gets two models of its own, as the hand-routed model was its second.IamRestRouteCoverageTestreads every model, and builds each request from what its routerequires.Type of change
fix:)feat:)feat!:orfix!:)AWS Compatibility
No behavior changes: no scope was hand-routed.
Checklist
./mvnw testpasses locally (ranIamRestRoutesTest,IamRestRouteCoverageTest,IamActionRegistryTest,IamAuthorizedActionsTest,IamEnforcementFilterTestandIamRestRouteEnforcementIntegrationTest, not the whole suite)