Skip to content

chore(iam): regenerate the IAM tables for what AWS has since changed - #9149

Merged
pgermosen merged 1 commit into
mainfrom
chore/iam-data-upstream-drift
Nov 21, 2026
Merged

pgermosen merged 1 commit into
mainfrom
chore/iam-data-upstream-drift

Conversation

@pgermosen

Copy link
Copy Markdown
Member

Summary

The "Vendored IAM data still matches upstream" check fails on main, and on every PR that touches IAM data, because AWS's Service Reference has changed since the tables were last generated. This regenerates each table with its own generator, unchanged, against the current reference and the pinned botocore 1.43.118.

  • iam-request-resources.json (make iam-request-resources-sync):
    • The reference no longer lists glue:DeleteAssetType and glue:PutAssetType.
    • QuickSight's TagResource, UntagResource and ListTagsForResource take the knowledgeBase type, and SearchKnowledgeBases now takes no type.
    • It adds AWS's new QuickSight (access control applications, inbound connectors, knowledge base refresh schedules, policy assignments), Route 53 and Textract (blueprints, projects, document insights) operations. 5,289 operations become 5,330.
  • iam-tag-on-create.json (make iam-tag-on-create-sync):
    • kinesisanalytics:CreateSnapshot, lambda:CreateRuntime and sagemaker:CreateClusterExtension now take the request's tags.
    • It adds AWS's new creates that tag, eight of them, in EC2, Glue, Kinesis, SageMaker and Textract. Those the pinned botocore doesn't model yet are recorded as not read, as before.
  • iam-condition-keys.json (make iam-condition-keys-sync): IAM's SAML and OpenID Connect provider actions take six new Identity Center keys. None names a request member, so each is recorded as not read.
  • iam-service-namespaces.json: 7 namespaces added.
  • iam-action-resources.json: IAM's GetRequestAuthorizationDetails, GetRequestAuthorizationPolicy and UpdateOpenIDConnectProvider added.
  • iam-authorized-actions.json: 5 actions listed with no resource type, in Glue, Lambda, QuickSight and Route 53.
  • Left as it is: iam-passed-roles.json.
    • The reference lists iam:PassRole on EventBridge's new CreateEventSource and UpdateEventSource. Botocore's eventbridgev2 model gives their requests no member naming a role, so the generator stops on them.
    • The verify reports the table as incomplete, not wrong, so it doesn't fail the check.

Type of change

  • Bug fix (fix:)
  • New feature (feat:)
  • Breaking change (feat!: or fix!:)
  • Docs / chore

AWS Compatibility

The Service Reference, retrieved 2026-11-21:

  • glue.json no longer has DeleteAssetType or PutAssetType.
  • quicksight.json gives SearchKnowledgeBases no resource types.
  • iam.json lists iam:EnableIdentityCenterAssociation, iam:RequestIdentityProviderIssuers and four more keys on CreateSAMLProvider, UpdateSAMLProvider, CreateOpenIDConnectProvider and UpdateOpenIDConnectProvider.
  • events.json lists CreateEventSource with {"Name": "PassRole", "Context": {"iam:PassedToService": ["events.amazonaws.com"]}, "Service": "iam"}, for the eventbridgev2 client's create_event_source.

Checklist

  • ./mvnw test passes locally (ran AwsServiceNamespacesTest, CognitoServiceTest, IamActionResourcesTest, IamAuthorizedActionsTest, IamPolicyEvaluatorTest, IamRestRouteCoverageTest, RequestResourceMembersTest, RequestResourcesTest, TagOnCreateMembersTest, TagOnCreateTest, VendoredResourcesTest and the Control Tower tag-on-create, IAM tag-on-create, IAM tag validation, tag-on-create namespaces, tag-on-create unknown region, unresolved resource types and REST-route enforcement integration tests, not the whole suite)
  • New or updated integration test added
  • Commit messages follow Conventional Commits
  • I have no more than 2 open, non-draft pull requests and no more than 4 open pull requests in total (drafts included) in this repository (maintainers and dependency bots are exempt).

The vendored-data check against AWS's Service Reference fails on main: the reference no longer lists
glue:DeleteAssetType and glue:PutAssetType, gives QuickSight's tagging actions the knowledgeBase type and
SearchKnowledgeBases none, has kinesisanalytics:CreateSnapshot, lambda:CreateRuntime and
sagemaker:CreateClusterExtension take the request's tags, and adds Identity Center condition keys to IAM's
SAML and OpenID Connect provider actions. Each table is regenerated by its own generator, unchanged:
request resources (QuickSight, Route 53 and Textract operations added, the two Glue actions dropped), tag
on create, IAM condition keys, the service namespaces (7 added), IAM's action resources (3 actions) and the
actions without resource types (5).

The passed-roles table stays as it is. The reference lists iam:PassRole on EventBridge's new
CreateEventSource and UpdateEventSource, whose requests in botocore's eventbridgev2 model name no role, so
the generator stops; the verify reports that table incomplete, not wrong.
@pgermosen pgermosen added chore iam AWS Identity and Access Management (IAM) labels Nov 21, 2026
@qodo-code-review

qodo-code-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

PR Summary by Qodo

Regenerate vendored IAM tables for AWS Service Reference drift

⚙️ Configuration changes 🐞 Bug fix 🕐 20-40 Minutes

Grey Divider

AI Description

• Regenerate six IAM tables against AWS’s current Service Reference to restore drift verification.
• Capture new actions, namespaces, resource types, creation tags, and Identity Center condition
 keys.
• Leave passed-role data unchanged because new EventBridge requests expose no role member.
Merge Risk 🟡 Medium

Blast radius 🟡 Medium 💥 2 capabilities

  • 2 affected capabilities within one bounded functional scope: IAM authorization and policy context.
  • The changed generated request-resource entries and their consumer form one bounded resource-authorization behavior across the generated table and resolver.
  • Namespace expansion is a distinct system outcome—service reachability reporting—from per-request authorization, but remains within the same bounded IAM policy-analysis integration.
  • The catalog is consumed directly by IamPolicyEvaluator.
Behavioral complexity 🟢 Low 🧩 Straightforward

  • Before: the existing resolver already selected generated operation metadata and applied established ARN/resource matching.
  • After: this PR changes the data rows and adds/removes direct operation mappings, without introducing a new algorithm, state machine, concurrency protocol, or cross-table write invariant.
  • New correctness condition: each changed AWS operation must map to exactly the resource types and request members that AWS authorizes.
  • The potential breadth comes from the number of generated rows, not from newly interacting logic.
Potential damage 🔴 High 🩹 Confidentiality

  • Conservative damage bound for the originating changed behavior; downstream capabilities remain contained.
  • A condition-context error can make a resource/tag/account restriction fail open, allowing access that the policy intended to deny.
  • Reverting the catalog fixes future evaluations but cannot automatically retract data already read or undo writes performed under an incorrect decision.
  • Rollback repairs future authorization.
  • External reads, writes, or downstream effects require audit and service-specific compensation; no automatic state repair is shown.
Assessed commit 319eb49
Diagram

graph TD
  AWS["AWS Service Reference"] --> Gen["IAM generators"] --> Tables["Vendored IAM tables"] --> Runtime["IAM authorization"]
  Botocore["Pinned botocore"] --> Gen
  Tables --> Verify["Drift verification"]
  AWS --> Verify
Loading
High-Level Assessment

Regenerating each table with its existing generator is appropriate: it preserves the established derivation and verification paths without introducing hand-maintained exceptions. Changing generators or pinning an older AWS reference would not address the upstream drift.

Files changed (6) +106 / -16

Other (6) +106 / -16
iam-action-resources.jsonAdd three IAM action-to-resource entries +6/-1

Add three IAM action-to-resource entries

• Adds two request-authorization actions with no resource type and maps UpdateOpenIDConnectProvider to oidc-provider. Refreshes the reference retrieval date.

src/main/resources/aws/iam-action-resources.json

iam-authorized-actions.jsonRegister five actions without resource types +6/-1

Register five actions without resource types

• Adds Glue, Lambda, QuickSight, and Route 53 actions to the authorized-action table, including SearchKnowledgeBases after AWS removed its resource type. Refreshes the reference retrieval date.

src/main/resources/aws/iam-authorized-actions.json

iam-condition-keys.jsonRecord new IAM Identity Center condition keys +25/-1

Record new IAM Identity Center condition keys

• Adds six condition-key types and records their applicability to SAML and OpenID Connect provider actions. Marks the new action/key combinations as unreadable from request members or, for UpdateOpenIDConnectProvider, absent from the pinned SDK model.

src/main/resources/aws/iam-condition-keys.json

iam-request-resources.jsonRefresh request-resource mappings for AWS action changes +48/-7

Refresh request-resource mappings for AWS action changes

• Removes two retired Glue actions, adds QuickSight, Route 53, and Textract operations, and adjusts QuickSight knowledge-base tagging and search resource types. The operation table grows from 5,289 to 5,330 entries.

src/main/resources/aws/iam-request-resources.json

iam-service-namespaces.jsonAdd seven AWS IAM service namespaces +8/-1

Add seven AWS IAM service namespaces

• Adds abuse, agent-discovery, apex, apiportal, bcm-data-hub, osm, and workload-telemetry from the current service index. Refreshes the retrieval date.

src/main/resources/aws/iam-service-namespaces.json

iam-tag-on-create.jsonRefresh creation-tag authorization metadata +13/-5

Refresh creation-tag authorization metadata

• Adds eight newly listed tagging creates across EC2, Glue, Kinesis, SageMaker, and Textract, marking operations absent from pinned botocore as not read. Also records request-tag conditions for three existing creates and adds apiportal to other namespaces.

src/main/resources/aws/iam-tag-on-create.json

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@pgermosen
pgermosen merged commit 26c090d into main Nov 21, 2026
28 checks passed
@pgermosen
pgermosen deleted the chore/iam-data-upstream-drift branch November 21, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore iam AWS Identity and Access Management (IAM)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant