Repository navigation
chore(iam): regenerate the IAM tables for what AWS has since changed - #9149
Merged
Merged
Conversation
The vendored-data check against AWS's Service Reference fails on main: the reference no longer lists glue:DeleteAssetType and glue:PutAssetType, gives QuickSight's tagging actions the knowledgeBase type and SearchKnowledgeBases none, has kinesisanalytics:CreateSnapshot, lambda:CreateRuntime and sagemaker:CreateClusterExtension take the request's tags, and adds Identity Center condition keys to IAM's SAML and OpenID Connect provider actions. Each table is regenerated by its own generator, unchanged: request resources (QuickSight, Route 53 and Textract operations added, the two Glue actions dropped), tag on create, IAM condition keys, the service namespaces (7 added), IAM's action resources (3 actions) and the actions without resource types (5). The passed-roles table stays as it is. The reference lists iam:PassRole on EventBridge's new CreateEventSource and UpdateEventSource, whose requests in botocore's eventbridgev2 model name no role, so the generator stops; the verify reports that table incomplete, not wrong.
PR Summary by QodoRegenerate vendored IAM tables for AWS Service Reference drift
AI Description
Merge Risk
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Vendored IAM data still matches upstream" check fails on main, and on every PR that touches IAM data, because AWS's Service Reference has changed since the tables were last generated. This regenerates each table with its own generator, unchanged, against the current reference and the pinned botocore 1.43.118.
iam-request-resources.json(make iam-request-resources-sync):glue:DeleteAssetTypeandglue:PutAssetType.TagResource,UntagResourceandListTagsForResourcetake theknowledgeBasetype, andSearchKnowledgeBasesnow takes no type.iam-tag-on-create.json(make iam-tag-on-create-sync):kinesisanalytics:CreateSnapshot,lambda:CreateRuntimeandsagemaker:CreateClusterExtensionnow take the request's tags.iam-condition-keys.json(make iam-condition-keys-sync): IAM's SAML and OpenID Connect provider actions take six new Identity Center keys. None names a request member, so each is recorded as not read.iam-service-namespaces.json: 7 namespaces added.iam-action-resources.json: IAM'sGetRequestAuthorizationDetails,GetRequestAuthorizationPolicyandUpdateOpenIDConnectProvideradded.iam-authorized-actions.json: 5 actions listed with no resource type, in Glue, Lambda, QuickSight and Route 53.iam-passed-roles.json.iam:PassRoleon EventBridge's newCreateEventSourceandUpdateEventSource. Botocore'seventbridgev2model gives their requests no member naming a role, so the generator stops on them.Type of change
fix:)feat:)feat!:orfix!:)AWS Compatibility
The Service Reference, retrieved 2026-11-21:
glue.jsonno longer hasDeleteAssetTypeorPutAssetType.quicksight.jsongivesSearchKnowledgeBasesno resource types.iam.jsonlistsiam:EnableIdentityCenterAssociation,iam:RequestIdentityProviderIssuersand four more keys onCreateSAMLProvider,UpdateSAMLProvider,CreateOpenIDConnectProviderandUpdateOpenIDConnectProvider.events.jsonlistsCreateEventSourcewith{"Name": "PassRole", "Context": {"iam:PassedToService": ["events.amazonaws.com"]}, "Service": "iam"}, for theeventbridgev2client'screate_event_source.Checklist
./mvnw testpasses locally (ranAwsServiceNamespacesTest,CognitoServiceTest,IamActionResourcesTest,IamAuthorizedActionsTest,IamPolicyEvaluatorTest,IamRestRouteCoverageTest,RequestResourceMembersTest,RequestResourcesTest,TagOnCreateMembersTest,TagOnCreateTest,VendoredResourcesTestand the Control Tower tag-on-create, IAM tag-on-create, IAM tag validation, tag-on-create namespaces, tag-on-create unknown region, unresolved resource types and REST-route enforcement integration tests, not the whole suite)