Repository navigation
Conversation
PR Summary by QodoBind CloudWatch Logs ARN tag operations to the owning log group
AI Description
Diagram
High-Level Assessment
Files changed (11)
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Code Review by Qodo
1.
|
|
@pgermosen Both review findings are addressed: incomplete ARN prefixes stay literal, and noncanonical markers cannot select a shortened local group name. The new HTTP and SDK regressions pass, and the fresh CI checks pass. Ready for another look. |
pgermosen
left a comment
There was a problem hiding this comment.
@electrum thanks, the ARN binding and the condition keys look right to me, and both Qodo points are settled. Not approving yet, though, because the tests copy existing harnesses.
CloudWatchLogsArnTagAuthorizationTest repeats the setUp, cleanup, policy, assertDenied and client of CloudWatchLogsStreamAuthorizationTest almost line for line. LogsArnTagAuthorizationIntegrationTest copies call and user from LogsStreamAuthorizationIntegrationTest, and the new test in LogsUnknownRegionAuthorizationIntegrationTest inlines another user plus PutUserPolicy block and the same tag body and expected tags as invoke and expectedTags.
Could you pull these into shared fixtures, the IAM side next to EnforcementFixtures, and move the existing Logs copies onto them?
pgermosen
left a comment
There was a problem hiding this comment.
@electrum thanks, that's the shape I was after: LogsAuthorizationFixtures builds its users on EnforcementFixtures, both SDK tests extend one CloudWatchLogsAuthorizationFixture, and the existing stream and unknown-region tests now use them too. This looks good to me.
Summary
CloudWatch Logs ARN tag operations now authorize and access the same locally owned log group. Policies can grant or deny a group’s bare ARN and use its stored tags, requested tags and removal keys without a foreign ARN reading or changing a local group.
Literal plain names remain intact, including incomplete
arn:prefixes; embedded markers cannot select a shortened local name. Canonical local ARN:*compatibility is retained. Tagging other Logs resource types remains unsupported.Type of change
fix:)AWS Compatibility
Covers
TagResource,UntagResourceandListTagsForResourcefor log groups, including account, region and partition isolation, denied-mutation state and historical stored-name collisions. Preserves upstream rejection of colon-bearing credential regions.Checked with 453 affected service/IAM/HTTP tests and AWS SDK for Java 2.55.11 on Java 17: 18 tests each in
us-east-1andcn-north-1. Package, Checkstyle, committed documentation and partition checks pass.The IAM and Java SDK authorization tests share fixtures with the existing Logs stream tests, including the unknown-region and partition cases.
Checklist