Repository navigation
fix(ec2): keep AWS-managed instance tags read-only - #333
Merged
fredpena merged 5 commits intoOct 14, 2026
Merged
Conversation
Signed-off-by: Andre Kurait <akurait@amazon.com>
Contributor
|
Signed-off-by: Andre Kurait <akurait@amazon.com>
This was referenced Oct 14, 2026
Signed-off-by: Andre Kurait <akurait@amazon.com>
…-editor Signed-off-by: Andre Kurait <akurait@amazon.com>
Signed-off-by: Andre Kurait <akurait@amazon.com>
4 of 5 tasks
Contributor
|
Thank you @AndreKurait, this is a careful fix, and each Greptile point landed with a regression test. No blockers from my side. |
Member
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Ashish50514561
pushed a commit
to Ashish50514561/floci-ui
that referenced
this pull request
Oct 15, 2026
# [0.7.0](floci-io/floci-ui@0.6.0...0.7.0) (2026-10-15) ### Bug Fixes * **api:** cap IAM user and role names at 64 characters ([floci-io#317](floci-io#317)) ([b11c8fb](floci-io@b11c8fb)), closes [floci-io/floci#5374](floci-io/floci#5374) * **api:** reject fractional maxMessages when receiving SQS messages ([floci-io#324](floci-io#324)) ([33688f6](floci-io@33688f6)), closes [floci-io#300](floci-io#300) * **api:** return SQS message attribute data types and test receive va… ([floci-io#321](floci-io#321)) ([55ed4af](floci-io@55ed4af)), closes [floci-io#303](floci-io#303) [floci-io#297](floci-io#297) [floci-io#297](floci-io#297) * **ec2:** keep AWS-managed instance tags read-only ([floci-io#333](floci-io#333)) ([a21f26e](floci-io@a21f26e)) * **ec2:** reject subnet layouts outside VPC boundaries ([floci-io#334](floci-io#334)) ([24f5679](floci-io@24f5679)) * **frontend:** close heading outline gaps and label form controls ([floci-io#345](floci-io#345)) ([ae32005](floci-io@ae32005)) * **frontend:** keep tables and split panels usable on narrow screens ([floci-io#339](floci-io#339)) ([6401b24](floci-io@6401b24)) * **frontend:** make every modal a focus-trapped dialog ([floci-io#336](floci-io#336)) ([f439e7e](floci-io@f439e7e)) * **frontend:** raise low-contrast text and move colours to tokens ([floci-io#338](floci-io#338)) ([c960efb](floci-io@c960efb)) ### Features * **aws:** add CloudFront distributions to the Cloud Explorer ([floci-io#330](floci-io#330)) ([deb8bdf](floci-io@deb8bdf)) * **aws:** add ECS clusters to the Cloud Explorer ([floci-io#327](floci-io#327)) ([70d1b2d](floci-io@70d1b2d)), closes [floci-io#304](floci-io#304) * **aws:** add Route 53 hosted zones to the Cloud Explorer ([floci-io#331](floci-io#331)) ([6f1dfbb](floci-io@6f1dfbb)) * **dynamodb:** add a PartiQL editor and paged scans to the table explorer ([floci-io#328](floci-io#328)) ([f264870](floci-io@f264870)), closes [floci-io#319](floci-io#319) * **frontend:** add custom message attributes to SQS send and receive ([floci-io#303](floci-io#303)) ([9d58d71](floci-io@9d58d71)) * **frontend:** cycle the top-bar theme button through Dark, Light, System ([floci-io#346](floci-io#346)) ([b464ed2](floci-io@b464ed2)) * **sqs:** support queue settings on creation and display queue in details ([floci-io#342](floci-io#342)) ([d1d46f2](floci-io@d1d46f2)) ### Performance Improvements * **frontend:** load service panels and secondary pages on demand ([floci-io#337](floci-io#337)) ([3ef65c3](floci-io@3ef65c3))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EC2 tag editors now display
aws:tags read-only, exclude them from mutation requests, and reject new reserved keys while allowing corrections. Both console paths use the same editor. This is the separate UI follow-up for floci-io/floci#5611.Saving preserves the visible draft until the instance refresh completes. Editing is disabled during that request, so a later save compares against the newly loaded tags. Unsaved edits still survive unrelated background refreshes.
Type of change
fix:)Validation
Live AWS checks in
us-east-2on 2026-10-13 confirmed that public EC2 tagging rejectsaws:,AWS:and mixed-case reserved keys. The backend PR records the AWS request evidence.On 2026-10-14: all 1,739 API tests and 101 frontend tests pass, along with
pnpm lint,pnpm type-check, andpnpm build. Tests cover both editor paths, reserved-key correction, preservation of external tags, delayed refreshes, disabled in-flight edits, and subsequent saves. No dependency changes.Checklist