Skip to content

Add Subhound 1.2#1078

Open
maxwalks wants to merge 4 commits into
flipperdevices:mainfrom
maxwalks:maxwalks/subhound_1.2
Open

Add Subhound 1.2#1078
maxwalks wants to merge 4 commits into
flipperdevices:mainfrom
maxwalks:maxwalks/subhound_1.2

Conversation

@maxwalks

@maxwalks maxwalks commented Jun 6, 2026

Copy link
Copy Markdown

Application Submission

  • Automated classifier for Flipper Zero BinRAW .sub captures. Identifies 17 ISM-band signal types — garage remotes, TPMS, weather stations, utility meters, alarm sensors, and more — with reasoning chain and confidence scoring.

  • Initial submission (v1.2). Source: https://github.com/maxwalks/subhound

Extra Requirements

  • None

Author Checklist (Fill this out)

  • I've read the contribution guidelines and my PR follows them
  • I own the code I'm submitting or have code owner's permission to submit it
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip

AI usage disclosure (Fill this out):

  • Partially AI assisted (clarify below which code was AI assisted and briefly explain what it does).

  • Fully AI generated (explain what all the generated code does in moderate detail).

  • AI was used as a coding/writing assistant during development of both the Python reference (analyze.py) and the C Flipper port (flipper-app/), and to draft the catalog metadata for this submission (CATALOG.md, docs/changelog.md, manifest.yml). All classifier rules, thresholds, and decoder logic were authored, reviewed, and tested by me against real on-device captures. The two implementations are kept in deliberate 1:1 parity with a regression test suite (tests/test_parity.py).

Reviewer Checklist (Don't fill this out!)

  • Bundle is valid
  • There are no obvious issues with the source code
  • I've ran this application and verified its functionality

Copilot AI review requested due to automatic review settings June 6, 2026 21:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a new manifest for the Subhound Sub-GHz application to describe its source location, description/changelog references, and screenshots for catalog/display purposes.

Changes:

  • Added manifest.yml defining the app’s git source (origin + pinned commit + subdir)
  • Wired manifest metadata to external markdown files for description and changelog
  • Added screenshot entries for UI/catalog previews

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +7 to +8
description: "@CATALOG.md"
changelog: "@./docs/changelog.md"
@xMasterX

xMasterX commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Hello, I made 2 changes in the app
1 - Added icon for .sub files in browser
2 - Disabled debug heap logs

Here is the updated version, you can commit that into your repo and update commit sha here
flipper-app.zip

Also btw, why app tries to analyse signal only by using some custom methods when you can try passing that into decoders that are in firmware API ? As an option or maybe before in-app analysis, like in 2 steps, if protocol is unknown we fallback into current analysis functions
Current idea works for totally unknown protocols, but known ones are not checked against existing decoders and may look like something new, while its not, you can try adding that option to check file against firmware subghz decoders too in next updates maybe, that would be very useful
(this is not change request for merge, just an idea to think about)

@xMasterX xMasterX added fixes needed Unresolved issues with the app requiring maintainer's attention Awaiting Merges Depends on dev branch or non-merged PRs and removed fixes needed Unresolved issues with the app requiring maintainer's attention labels Jun 8, 2026

@xMasterX xMasterX left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update app using provided archive above to fix missing icon and debug logs
Don't forget to change commit sha after that and tag me when its ready

@maxwalks

maxwalks commented Jun 9, 2026

Copy link
Copy Markdown
Author

@xMasterX done, thanks for the patch. Applied your changes and bumped the commit_sha. Will get the firmware-decoder fallback in for the next release.

@xMasterX

xMasterX commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

You need to fix readme / changelog files

[E] Markdown error: Markdown element 'Backtick' is not allowed

@xMasterX xMasterX added fixes needed Unresolved issues with the app requiring maintainer's attention and removed Awaiting Merges Depends on dev branch or non-merged PRs labels Jun 9, 2026
@maxwalks

Copy link
Copy Markdown
Author

@xMasterX The markdown errors should be resolved now, I've removed the backticks and updated the commit_sha. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (new) fixes needed Unresolved issues with the app requiring maintainer's attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants