Skip to content

Add FlipPar 0.1#1001

Open
jsammarco wants to merge 10 commits into
flipperdevices:mainfrom
jsammarco:jsammarco/flippar_0.1
Open

Add FlipPar 0.1#1001
jsammarco wants to merge 10 commits into
flipperdevices:mainfrom
jsammarco:jsammarco/flippar_0.1

Conversation

@jsammarco

Copy link
Copy Markdown

No description provided.

@jsammarco

jsammarco commented Mar 31, 2026

Copy link
Copy Markdown
Author

Please consider my app as I think the golf and frolf community would really enjoy it
Thank you
Joe

@jsammarco

Copy link
Copy Markdown
Author

Am I just waiting for a review here?

@xMasterX xMasterX left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, app does not work if opened via ufbt launch or fbt launch or if it is launched via quick buttons at desktop
App gui refresh relies on old "bug" with hourglass animation forcing gui update in background if app was started from "Apps" menu

Please fix GUI update, it needs to be handled by app itself, forcing screen update when it needs it

@xMasterX xMasterX added the fixes needed Unresolved issues with the app requiring maintainer's attention label Apr 15, 2026

@jsammarco jsammarco left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes to fix the start up bug and updated commit sha

@jsammarco

Copy link
Copy Markdown
Author

Let me know if anything else is needed.

@jsammarco

Copy link
Copy Markdown
Author

Sorry to bug but is there a backlog? Or is there still an issue with my repo/submission?

@jsammarco

Copy link
Copy Markdown
Author

It would be really nice to know what the delay is???

@xMasterX

xMasterX commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

I will let you know if there's any issue when I test it, i'm currently doing re-reviews and new PRs so if it passes testing it will be merged today, delay mostly was caused cuz there's a lot of PR's to go trough, since I'm also doing some research and development this may take some time, but nothing will be forgotten :) 100%

@xMasterX xMasterX mentioned this pull request Jun 8, 2026
@xMasterX

xMasterX commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Tested, Issue with GUI is now fixed, however there's another was found by manifest validator

[E] Icon icon.png is not black and white

Please update it to use #00000 and #FFFFF colors
Then update commit sha here to point to latest one with fixed icon, tag me when its ready

@jsammarco

Copy link
Copy Markdown
Author

@xMasterX
Thanks for the response. Made the BW icon fix.
commit sha updated in yaml
Joe

@xMasterX

xMasterX commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

@xMasterX Thanks for the response. Made the BW icon fix. commit sha updated in yaml Joe

Ran both your apps trough tests, issue is the same
[E] Icon icon.png is not black and white
On both

Hmm, maybe you wanna re-do them via something like this
https://www.pixilart.com/draw

All pixels have to be 1 bit black or white, maybe changes was not applied?

@xMasterX

xMasterX commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

I see, you did update in the repo but not updated commit sha here, i did that for you, but I noticed another issue
Screenshots of the app is not taken via qFlipper and have wrong resolution
1024 × 512

It should be 512x256
Please remake them, and let me know when its ready, same for this app
#1003

Screenshots and commit sha, last one I can update for you here, but screenshots has to be fixed manually by author

@jsammarco

jsammarco commented Jun 9, 2026

Copy link
Copy Markdown
Author

I see, you did update in the repo but not updated commit sha here, i did that for you, but I noticed another issue Screenshots of the app is not taken via qFlipper and have wrong resolution 1024 × 512

It should be 512x256 Please remake them, and let me know when its ready, same for this app #1003

Screenshots and commit sha, last one I can update for you here, but screenshots has to be fixed manually by author

@xMasterX
Fixed this in both repos. Please re-run builds
Joe

@xMasterX

xMasterX commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

They should be re-created via qFlipper, resize software you used made them "smooth"
Which will break them after the merge
Pics should be pixel perfect without shadows, only 2 colors, no grey shades at all

Screenshot 2026-06-09 at 05 31 59

@jsammarco

jsammarco commented Jun 9, 2026

Copy link
Copy Markdown
Author

They should be re-created via qFlipper, resize software you used made them "smooth" Which will break them after the merge Pics should be pixel perfect without shadows, only 2 colors, no grey shades at all

Screenshot 2026-06-09 at 05 31 59

@xMasterX
Really sorry about these bugs.
Got them both fixed, no blur or aliasing.
Thanks for working with me
Joe

@xMasterX

xMasterX commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Now there's another issue

[E] Markdown error: Markdown element 'Header Depth' max level 2 exceeded

In readme or changelog

@jsammarco

Copy link
Copy Markdown
Author

Now there's another issue

[E] Markdown error: Markdown element 'Header Depth' max level 2 exceeded

In readme or changelog

@xMasterX Fixed

@jsammarco

Copy link
Copy Markdown
Author

@xMasterX
Are we ready or are there any more changes?
Thank you
Joe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (new) fixes needed Unresolved issues with the app requiring maintainer's attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants