Skip to content

Add changes for fleetd v1.56.3#47451

Open
lucasmrod wants to merge 1 commit into
mainfrom
release-notes-fleetd-v1.56.3
Open

Add changes for fleetd v1.56.3#47451
lucasmrod wants to merge 1 commit into
mainfrom
release-notes-fleetd-v1.56.3

Conversation

@lucasmrod

@lucasmrod lucasmrod commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Fixed agent handling of osquery command line flags. The system now correctly preserves pre-packaged flagfiles when the flag setting is unset, while continuing to clear flags when explicitly set to empty.

@lucasmrod lucasmrod requested a review from a team as a code owner June 11, 2026 19:43
Copilot AI review requested due to automatic review settings June 11, 2026 19:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the Orbit/fleetd release notes for fleetd v1.56.3 by moving a previously-staged change entry into orbit/CHANGELOG.md and removing the now-consumed orbit/changes/ entry file.

Changes:

  • Added a new ## 1.56.3 (Jun 11, 2026) section to the Orbit changelog with the relevant user-visible fix.
  • Removed the corresponding orbit/changes/47285-preserve-prepackaged-osquery-flags entry after incorporating it into the changelog.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
orbit/changes/47285-preserve-prepackaged-osquery-flags Removes the consumed change entry now that it’s been added to the changelog.
orbit/CHANGELOG.md Adds the 1.56.3 release section and includes the change note describing the fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a0b3df0a-0e76-4fa9-8bd0-2d14ec401cfb

📥 Commits

Reviewing files that changed from the base of the PR and between 6735479 and fd69917.

⛔ Files ignored due to path filters (1)
  • orbit/CHANGELOG.md is excluded by !**/*.md
📒 Files selected for processing (1)
  • orbit/changes/47285-preserve-prepackaged-osquery-flags
💤 Files with no reviewable changes (1)
  • orbit/changes/47285-preserve-prepackaged-osquery-flags

Walkthrough

This PR updates a changelog entry in orbit/changes/47285-preserve-prepackaged-osquery-flags that documents the behavior of fleetd's handling of pre-packaged osquery flagfiles. The change clarifies that when the command_line_flags agent setting is unset, the system clears the flagfile, while explicitly setting it to an empty document ({} or null) continues to clear it. This is a minimal documentation update reflecting existing or intended behavior.

Possibly related issues

Possibly related PRs

  • fleetdm/fleet#47305: Implements the underlying changes to orbit/pkg/update/flag_runner.go for the osquery.flags and command_line_flags behavior that this changelog entry describes.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author, making it impossible to verify compliance with the repository's required description template and checklist items. Add a comprehensive pull request description following the repository template, including the related issue number, relevant checklist items, and explanation of changes.
Title check ❓ Inconclusive The title is vague and generic, using non-descriptive language ('Add changes for fleetd v1.56.3') that does not convey meaningful information about the actual changeset regarding osquery flagfile handling. Revise the title to specifically describe the main change, such as 'Preserve pre-packaged osquery flags behavior in fleetd v1.56.3' or similar.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release-notes-fleetd-v1.56.3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants