-
Notifications
You must be signed in to change notification settings - Fork 908
Warn users about file carving size limits #47376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
noahtalerman
wants to merge
9
commits into
main
Choose a base branch
from
noahtalerman-patch-84
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−39
Draft
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cf63e57
Update rest-api.md
noahtalerman 53d0afa
Create file-carving.md
noahtalerman 1d05837
Apply suggestion from @noahtalerman
noahtalerman 04f9768
Update file-carving.md
noahtalerman fc9a50d
Apply suggestion from @noahtalerman
noahtalerman 4e6a711
Apply suggestion from @noahtalerman
noahtalerman ad97563
Delete docs/Contributing/product-groups/orchestration/file-carving.md
noahtalerman 08178fc
Apply suggestion from @noahtalerman
noahtalerman 7003ef2
Update file-carving.md
noahtalerman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rfairburn when you get the chance, can you please help me come up w/ a good warning here?
So
shackletonand other customers know the best practice max: https://fleetdm.slack.com/archives/C094ZAWGDHC/p1779392158155149cc @zayhanlon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case you refer to there were a couple of things that at first glance happened that didn't seem intentional
The net effect was a load both in bandwidth and db usage that came from an X * Y * Z * A situation where:
X = number of hosts
Y = number of paths requests
Z = number of files in the paths
A = avg file size of any individual file
Any one of these can be bigger in scope usually without there being a huge issue for example:
However, when all four of the dials end up being turned up (on accident in this case from the sounds of it), you suddenly end up with the db trying to write millions of new rows of metatada, while fleet is trying to populate 10s of terrabytes of data in the s3 carves bucket, while all hosts are both responding to the distributed query that does the
SELECTto trigger the carve and push all of this data over the carves endpoints.Another gotcha that did not occur in this specific case is the carves in question were only a one-off. There wasn't a scheduled query/automations=on situation, which can also compound.
The only nuance is that a particular carve select with multiple files would get combined into a single tar archive before being transferred, but we would still be subject to the 8GB size, block size of 256mb (row and s3 object per block), and the 4th-power load amplification if all factors get scaled at once.