Skip to content

fix file picker handling for limited subforms #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flack merged 1 commit into from
Mar 16, 2026
Merged

fix file picker handling for limited subforms #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions static/midcom.datamanager/subform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ function init_subform(id, sortable, allow_add, allow_delete) {
container.trigger('sortupdate');
}
new_form.trigger('subformadded');

// If there is exactly one file selector, we're probably in some sort of attachment list,
// so let's assume the user wants to add a file
// (at some point this should probably be made configurable)
if (new_form.find('input[type="file"]').length === 1) {
new_form.find('input[type="file"]').trigger('click');
}
}

function update_add_button() {
Expand Down Expand Up @@ -71,13 +78,4 @@ function init_subform(id, sortable, allow_add, allow_delete) {
});
});
}

add_button.on('click', function() {
// If there is exactly one file selector, we're probably in some sort of attachment list,
// so let's assume the user wants to add a file
// (at some point this should probably be made configurable)
if ($(this).prev().find('input[type="file"]').length === 1) {
$(this).prev().find('input[type="file"]').click();
}
});
}
Loading