Skip to content

Evo: ignore stale block tip notifications - #1941

Draft
navidR wants to merge 1 commit into
firoorg:masterfrom
navidR:dev/navidr/ignore-stale-dmn-tip-notifications
Draft

Evo: ignore stale block tip notifications#1941
navidR wants to merge 1 commit into
firoorg:masterfrom
navidR:dev/navidr/ignore-stale-dmn-tip-notifications

Conversation

@navidR

@navidR navidR commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Ignore delayed deterministic-masternode tip notifications when their block is no longer the active chain tip. Add regressions covering stale callbacks and valid pure-disconnect updates after repeated invalidations.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@reubenyap reubenyap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current draft head. I traced queued tip notifications through the deterministic-masternode manager, checked every tipIndex reader, and verified the cs_main-to-manager lock order against block processing. The stale callback is rejected while current and null-tip updates still work, and the full CI matrix is green. I found no actionable issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants