LLMQ: Bound InstantSend lock intake - #1939
Conversation
Limit lock input vectors, bound the pending queue, and process at most 32 locks per pass. Add boundary regression tests.
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:L
User descriptionBound InstantSend input vectors and the pending-lock queue, and process at most 32 locks per pass. Add boundary coverage for each admission and processing limit. CodeAnt-AI DescriptionBound InstantSend lock intake and processing What Changed
Impact
💡 Usage GuideChecking Your Pull RequestEvery time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later. Talking to CodeAnt AIGot a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask: This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code. ExamplePreserve Org Learnings with CodeAntYou can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input: This helps CodeAnt AI learn and adapt to your team's coding style and standards. ExampleRetrigger reviewAsk CodeAnt AI to review the PR again, by typing: Check Your Repository HealthTo analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health. |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| if (islock.inputs.size() > CInstantSendLock::MAX_INPUTS) { | ||
| LOCK(cs_main); | ||
| Misbehaving(pfrom->id, 100); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggestion: The limit is checked only after deserialization, so a peer can still make the parser allocate and process a network-sized input vector before rejection. [resource leak]
Assessment: 🟠 Major · 🔁 Occurrence: Sometimes
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/llmq/quorums_instantsend.cpp
**Line:** 707:711
**Comment:**
*Resource Leak: The limit is checked only after deserialization, so a peer can still make the parser allocate and process a network-sized input vector before rejection.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| while (pend.size() < maxCount) { | ||
| auto it = pendingInstantSendLocks.begin(); | ||
| pend.emplace(it->first, std::move(it->second)); | ||
| pendingInstantSendLocks.erase(it); | ||
| } |
There was a problem hiding this comment.
Suggestion: Extracted locks are lost when InstantSend is disabled or quorum selection fails, because this partial drain never reinserts pend into pendingInstantSendLocks. [incomplete implementation]
Assessment: 🟠 Major · 🔁 Occurrence: Sometimes
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/llmq/quorums_instantsend.cpp
**Line:** 780:784
**Comment:**
*Incomplete Implementation: Extracted locks are lost when InstantSend is disabled or quorum selection fails, because this partial drain never reinserts `pend` into `pendingInstantSendLocks`.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
CodeAnt Nitpicks1 code suggestion1.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a5bdf138b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (pendingInstantSendLocks.size() >= MAX_PENDING_INSTANTSEND_LOCKS) { | ||
| LogPrint("instantsend", "CInstantSendManager::%s -- pending islock queue full (%d), dropping islock=%s, peer=%d\n", | ||
| __func__, pendingInstantSendLocks.size(), hash.ToString(), pfrom->id); | ||
| return; |
There was a problem hiding this comment.
A connected peer can fill this global first-come queue with distinct one-input locks because PreVerifyInstantSendLock does not authenticate the BLS signature; once it reaches 1024, valid locks from every other peer are dropped before verification. By continuously submitting BLS-valid but quorum-invalid signatures faster than the 32-item worker batches, an attacker can keep the queue full and suppress InstantSend lock intake, so the bound needs per-peer admission limits, fair eviction, or reserved capacity rather than an unconditional global drop.
AGENTS.md reference: AGENTS.md:L238-L245
Useful? React with 👍 / 👎.
| if (islock.inputs.size() > CInstantSendLock::MAX_INPUTS) { | ||
| LOCK(cs_main); | ||
| Misbehaving(pfrom->id, 100); | ||
| return; |
There was a problem hiding this comment.
When an unauthenticated peer sends an ISLOCK whose CompactSize input count exceeds MAX_INPUTS, vRecv >> islock has already allocated and parsed the entire vector before this check runs. The generic vector deserializer accepts counts up to MAX_SIZE, so a maximum-sized network message can force allocation and parsing of hundreds of thousands of COutPoints before the peer is banned, leaving the intended intake bound ineffective; read and validate the count before resizing the vector.
AGENTS.md reference: AGENTS.md:L238-L245
Useful? React with 👍 / 👎.
| // Only process 32 locks at a time to avoid duplicate verification of recovered signatures which have been | ||
| // verified by CSigningManager in parallel. | ||
| const size_t maxCount = 32; |
There was a problem hiding this comment.
When one peer has more than 128 locks that fail verification because they are old enough not to match either active quorum set, this cap splits them across at least five invocations. The existing verification path applies Misbehaving(nodeId, 20) once per bad source per invocation, so the default score reaches 100 and disconnects the peer; before this change the entire pending set produced only one 20-point penalty. This contradicts the nearby intent to be lenient toward peers relaying old locks, so penalties need to be deduplicated across a queue drain or entries need to be batched by source.
AGENTS.md reference: AGENTS.md:L238-L245
Useful? React with 👍 / 👎.
reubenyap
left a comment
reubenyap
left a comment
There was a problem hiding this comment.
Reviewed the intake limit, queue boundary and draining behavior, recovered-signature shortcut, callers, and boundary coverage. The 32-item passes continue draining safely and the exact-signature check preserves verification semantics. CI is green; I found no additional actionable defects beyond the logging-format mismatch already raised in the discussion.
2 participants
Bound InstantSend input vectors and the pending-lock queue, and process at most 32 locks per pass. Add boundary coverage for each admission and processing limit.
Upstream: Dash PR #7397 and Dash PR #3399.