LLMQ: Lock InstantSend input request IDs

[navidR]

Protect InstantSend input request-ID insertion with the manager mutex already used by readers and cleanup paths. This removes a cross-thread data race without changing protocol behavior.

Upstream: Dash PR #3829.

[coderabbitai]

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 444af9f8-a1de-41b4-9267-ef63c0bdb3d9

📥 Commits

Reviewing files that changed from the base of the PR and between 4f0c771 and 3a5cb6a.

📒 Files selected for processing (1)

• src/llmq/quorums_instantsend.cpp

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-08-30T14:57:11.145074Z	3a5cb6a	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[codeant-ai]

🤖 CodeAnt AI — Review Status

Status	Commit	Started (UTC)	Finished (UTC)
✅ Reviewed your PR	3a5cb6a	Aug 30, 2026 · 14:56	15:00

[codeant-ai]

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[codeant-ai]

User description

Protect InstantSend input request-ID insertion with the manager mutex already used by readers and cleanup paths. This removes a cross-thread data race without changing protocol behavior.

---

CodeAnt-AI Description

Prevent InstantSend request tracking from being accessed inconsistently during concurrent processing

What Changed

• InstantSend input request IDs are now protected while being added, matching the synchronization used when they are read or removed
• Concurrent transaction processing no longer risks a data race in request-ID tracking

Impact

✅ Fewer concurrency-related InstantSend errors
✅ Safer concurrent transaction processing

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[codeant-ai]

CodeAnt Nitpicks

1 code suggestion

1. These IDs are never removed when RemoveNonLockedTx drops a transaction, leaving stale IDs that can route later recovered signatures through obsolete transaction state.

Stale reference · src/llmq/quorums_instantsend.cpp:470-473

[reubenyap]

Reviewed the full change and the synchronization around every inputRequestIds access. The insertion now uses the same manager mutex as reads and cleanup, including re-entrant call paths, without changing protocol behavior. CI is green, and I found no new actionable defects.