Enable SingleMemoryStorageSchedule in test_checkpointing_validity#5169
Open
sghelichkhani wants to merge 1 commit into
Open
Enable SingleMemoryStorageSchedule in test_checkpointing_validity#5169sghelichkhani wants to merge 1 commit into
sghelichkhani wants to merge 1 commit into
Conversation
The test is parametrised over SingleMemory but never enabled that schedule, so the case silently compared two unscheduled tapes. Wire it up so the parametrisation does what its test id promises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_checkpointing_validityis parametrised over"Revolve","SingleMemory","NoneAdjoint","Mixed"andNone, but the body only enables the Revolve and Mixedschedules, so the SingleMemory case silently compared two unscheduled tapes. This adds the
missing
elifso that parametrisation does what its test id promises. Nothing new is caughtby this — the case passes against the released pyadjoint pin and against
dolfin-adjoint/pyadjoint#248 — it simply makes the test consistent with what it advertises.
"NoneAdjoint"is left unwired sinceNoneCheckpointScheduledoes not support the adjointsweep this test performs.