Fixes for BDDC#5152
Open
pbrubeck wants to merge 21 commits into
Open
Conversation
e11e7da to
2f8b06c
Compare
pbrubeck
commented
Jun 8, 2026
pbrubeck
commented
Jun 8, 2026
pbrubeck
commented
Jun 8, 2026
804646e to
1bc6e36
Compare
default values for options should guarantee robustness wrt H1,Hdiv and Hcurl problems
pbrubeck
commented
Jun 15, 2026
pbrubeck
commented
Jun 15, 2026
| @@ -34,9 +34,12 @@ class BDDCPC(PCBase): | |||
| the options: | |||
| - ``'bddc_cellwise'`` to set up a MatIS on cellwise subdomains if P.type == python, | |||
| - ``'bddc_matfree'`` to set up a matrix-free MatIS if A.type == python, | |||
Contributor
There was a problem hiding this comment.
Can you do matrix-free MatIS? Then the divergence matrix can be passed that way, I only need the action of its local part (in MATIS sense) on a given vector
Contributor
Author
There was a problem hiding this comment.
I think we need to fix support for matfree A in BDDC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Internal fixes required for BDDCPC to work on primal elasticity problems.
Adds new options
-pc_bddc_use_divergence_matand-pc_bddc_use_discrete_gradient. Their defaults are the correct ones for the Riesz map in the de Rham complex, H(curl) needs the gradient, while H(div) needs the divergence. The H1 Riesz map does not need an extra operator. However, elasiticity problems are posed on H1, but BDDC would need to be aware of the divergence, so in this case the user must prescribe it.