fix(memory): use checked arithmetic in memfd_backed region sum - #6140
Open
dan1d wants to merge 1 commit into
Open
fix(memory): use checked arithmetic in memfd_backed region sum#6140dan1d wants to merge 1 commit into
dan1d wants to merge 1 commit into
Conversation
The memfd_backed function used an unchecked .sum() to calculate the total size of memory regions. This could theoretically overflow if given sufficiently large region sizes. This change applies the same fix that was made to snapshot_file in commit 837c2e7: replace the unchecked sum with try_fold and checked_add, returning MemoryError::OffsetTooLarge on overflow. Signed-off-by: Daniel <danielfromarg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
memfd_backedfunction uses an unchecked.sum()to calculate the total size of memory regions:This could theoretically overflow if given sufficiently large region sizes.
This PR applies the same fix that was made to
snapshot_filein commit 837c2e7: replace the unchecked sum withtry_foldandchecked_add, returningMemoryError::OffsetTooLargeon overflow.Changes
.sum()with.try_fold()+checked_add()inmemfd_backedMemoryError::OffsetTooLargeon overflow (consistent withsnapshot_file)Test plan
snapshot_file(lines 909-912)Related
snapshot_file