Skip to content

[blk-threaded - 10/12] block: initialize worker on boot, restore, and hotplug - #6132

Open
PierreBertholom wants to merge 1 commit into
pbertho/blk-threaded-09from
pbertho/blk-threaded-10
Open

[blk-threaded - 10/12] block: initialize worker on boot, restore, and hotplug#6132
PierreBertholom wants to merge 1 commit into
pbertho/blk-threaded-09from
pbertho/blk-threaded-10

Conversation

@PierreBertholom

@PierreBertholom PierreBertholom commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

[10/12] part of the PR stack starting with #6123

Changes

Pass seccomp filters through all block device creation paths and spawn
a worker at attach time.
Return initialization errors when the worker filter is missing.

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.68657% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.85%. Comparing base (e3a30b2) to head (083f96e).

Files with missing lines Patch % Lines
src/vmm/src/rpc_interface.rs 25.00% 15 Missing ⚠️
src/firecracker/src/api_server_adapter.rs 0.00% 9 Missing ⚠️
src/vmm/src/builder.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           pbertho/blk-threaded-09    #6132      +/-   ##
===========================================================
- Coverage                    81.88%   81.85%   -0.04%     
===========================================================
  Files                          278      278              
  Lines                        31606    31657      +51     
===========================================================
+ Hits                         25882    25913      +31     
- Misses                        5724     5744      +20     
Flag Coverage Δ
5.10-m5n.metal 82.00% <62.68%> (-0.03%) ⬇️
5.10-m6a.metal 81.34% <62.68%> (-0.03%) ⬇️
5.10-m6g.metal 78.85% <62.68%> (-0.04%) ⬇️
5.10-m6i.metal 82.00% <62.68%> (-0.02%) ⬇️
5.10-m7a.metal-48xl 81.33% <62.68%> (-0.03%) ⬇️
5.10-m7g.metal 78.85% <62.68%> (-0.04%) ⬇️
5.10-m7i.metal-24xl 81.97% <62.68%> (-0.02%) ⬇️
5.10-m7i.metal-48xl 81.97% <62.68%> (-0.03%) ⬇️
5.10-m8g.metal-24xl 78.85% <62.68%> (-0.04%) ⬇️
5.10-m8g.metal-48xl 78.85% <62.68%> (-0.03%) ⬇️
5.10-m8i.metal-48xl 81.98% <62.68%> (-0.03%) ⬇️
5.10-m8i.metal-96xl 81.98% <62.68%> (-0.03%) ⬇️
6.1-m5n.metal 82.02% <62.68%> (-0.03%) ⬇️
6.1-m6a.metal 81.36% <62.68%> (-0.03%) ⬇️
6.1-m6g.metal 78.85% <62.68%> (-0.04%) ⬇️
6.1-m6i.metal 82.02% <62.68%> (-0.03%) ⬇️
6.1-m7a.metal-48xl 81.35% <62.68%> (-0.02%) ⬇️
6.1-m7g.metal 78.85% <62.68%> (-0.04%) ⬇️
6.1-m7i.metal-24xl 82.03% <62.68%> (-0.03%) ⬇️
6.1-m7i.metal-48xl 82.03% <62.68%> (-0.03%) ⬇️
6.1-m8g.metal-24xl 78.85% <62.68%> (-0.03%) ⬇️
6.1-m8g.metal-48xl 78.85% <62.68%> (-0.04%) ⬇️
6.1-m8i.metal-48xl 82.03% <62.68%> (-0.04%) ⬇️
6.1-m8i.metal-96xl 82.03% <62.68%> (-0.03%) ⬇️
6.18-m5n.metal 82.02% <62.68%> (-0.03%) ⬇️
6.18-m6a.metal 81.36% <62.68%> (-0.03%) ⬇️
6.18-m6g.metal 78.85% <62.68%> (-0.04%) ⬇️
6.18-m6i.metal 82.02% <62.68%> (-0.02%) ⬇️
6.18-m7a.metal-48xl 81.35% <62.68%> (-0.03%) ⬇️
6.18-m7g.metal 78.85% <62.68%> (-0.04%) ⬇️
6.18-m7i.metal-24xl 82.03% <62.68%> (-0.03%) ⬇️
6.18-m7i.metal-48xl 82.03% <62.68%> (-0.04%) ⬇️
6.18-m8g.metal-24xl 78.85% <62.68%> (-0.04%) ⬇️
6.18-m8g.metal-48xl 78.85% <62.68%> (-0.04%) ⬇️
6.18-m8i.metal-48xl 82.04% <62.68%> (-0.03%) ⬇️
6.18-m8i.metal-96xl 82.04% <62.68%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Pass seccomp filters through all block device creation paths and spawn
a worker at attach time.
Return initialization errors when the worker filter is missing.

Signed-off-by: Pierre Bertholom <pbertho@amazon.com>
@PierreBertholom
PierreBertholom force-pushed the pbertho/blk-threaded-10 branch from 0f688ac to 083f96e Compare August 19, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant