Skip to content

[blk-threaded - 6/12] block: add worker thread reset and teardown - #6127

Open
PierreBertholom wants to merge 1 commit into
pbertho/blk-threaded-05from
pbertho/blk-threaded-06
Open

[blk-threaded - 6/12] block: add worker thread reset and teardown#6127
PierreBertholom wants to merge 1 commit into
pbertho/blk-threaded-05from
pbertho/blk-threaded-06

Conversation

@PierreBertholom

@PierreBertholom PierreBertholom commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

[6/12] part of the PR stack starting with #6123

Changes

Add a reset path that returns data-path resources to the VMM thread
and parks the worker for reactivation.

Move ownership transitions into _reset() so failures are reported
before virtio state and queues are reset. Drain and join the active
worker thread when dropping the device.

Add a reset path that returns data-path resources to the VMM thread
and parks the worker for reactivation.

Move ownership transitions into `_reset()` so failures are reported
before virtio state and queues are reset. Drain and join the active
worker thread when dropping the device.

Signed-off-by: Pierre Bertholom <pbertho@amazon.com>
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.07937% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.48%. Comparing base (3e06e8d) to head (bccc3e7).

Files with missing lines Patch % Lines
src/vmm/src/devices/virtio/block/virtio/worker.rs 62.50% 15 Missing ⚠️
src/vmm/src/devices/virtio/block/virtio/device.rs 69.56% 7 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           pbertho/blk-threaded-05    #6127      +/-   ##
===========================================================
+ Coverage                    81.95%   82.48%   +0.53%     
===========================================================
  Files                          278      278              
  Lines                        31314    31356      +42     
===========================================================
+ Hits                         25663    25865     +202     
+ Misses                        5651     5491     -160     
Flag Coverage Δ
5.10-m5n.metal 82.69% <65.07%> (+0.59%) ⬆️
5.10-m6a.metal 82.04% <65.07%> (+0.61%) ⬆️
5.10-m6g.metal 79.54% <65.07%> (+0.61%) ⬆️
5.10-m6i.metal 82.68% <65.07%> (+0.58%) ⬆️
5.10-m7a.metal-48xl 82.03% <65.07%> (+0.61%) ⬆️
5.10-m7g.metal 79.54% <65.07%> (+0.61%) ⬆️
5.10-m7i.metal-24xl 82.66% <65.07%> (+0.58%) ⬆️
5.10-m7i.metal-48xl 82.66% <65.07%> (+0.58%) ⬆️
5.10-m8g.metal-24xl 79.54% <65.07%> (+0.61%) ⬆️
5.10-m8g.metal-48xl 79.54% <65.07%> (+0.61%) ⬆️
5.10-m8i.metal-48xl 82.66% <65.07%> (+0.59%) ⬆️
5.10-m8i.metal-96xl 82.66% <65.07%> (+0.59%) ⬆️
6.1-m5n.metal 82.71% <65.07%> (+0.58%) ⬆️
6.1-m6a.metal 82.06% <65.07%> (+0.61%) ⬆️
6.1-m6g.metal 79.54% <65.07%> (+0.61%) ⬆️
6.1-m6i.metal 82.71% <65.07%> (+0.58%) ⬆️
6.1-m7a.metal-48xl 82.05% <65.07%> (+0.61%) ⬆️
6.1-m7g.metal 79.54% <65.07%> (+0.61%) ⬆️
6.1-m7i.metal-24xl 82.72% <65.07%> (+0.58%) ⬆️
6.1-m7i.metal-48xl 82.72% <65.07%> (+0.58%) ⬆️
6.1-m8g.metal-24xl 79.53% <65.07%> (+0.61%) ⬆️
6.1-m8g.metal-48xl 79.54% <65.07%> (+0.61%) ⬆️
6.1-m8i.metal-48xl 82.73% <65.07%> (+0.59%) ⬆️
6.1-m8i.metal-96xl 82.72% <65.07%> (+0.58%) ⬆️
6.18-m5n.metal 82.71% <65.07%> (+0.58%) ⬆️
6.18-m6a.metal 82.07% <65.07%> (+0.62%) ⬆️
6.18-m6g.metal 79.54% <65.07%> (+0.61%) ⬆️
6.18-m6i.metal 82.71% <65.07%> (+0.59%) ⬆️
6.18-m7a.metal-48xl 82.05% <65.07%> (+0.61%) ⬆️
6.18-m7g.metal 79.54% <65.07%> (+0.61%) ⬆️
6.18-m7i.metal-24xl 82.72% <65.07%> (+0.58%) ⬆️
6.18-m7i.metal-48xl 82.72% <65.07%> (+0.59%) ⬆️
6.18-m8g.metal-24xl 79.54% <65.07%> (+0.61%) ⬆️
6.18-m8g.metal-48xl 79.54% <65.07%> (+0.61%) ⬆️
6.18-m8i.metal-48xl 82.72% <65.07%> (+0.58%) ⬆️
6.18-m8i.metal-96xl 82.72% <65.07%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant