Skip to content

[blk-threaded - 3/12] block: extract inline I/O processing into BlockWorker - #6125

Open
PierreBertholom wants to merge 1 commit into
pbertho/blk-threaded-02from
pbertho/blk-threaded-03
Open

[blk-threaded - 3/12] block: extract inline I/O processing into BlockWorker#6125
PierreBertholom wants to merge 1 commit into
pbertho/blk-threaded-02from
pbertho/blk-threaded-03

Conversation

@PierreBertholom

@PierreBertholom PierreBertholom commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

[3/12] part of the PR stack starting with #6123

Changes

Move queue and completion processing into BlockWorker while keeping
execution on the VMM thread.

Transfer runtime resources to the worker on activation and return them
on deactivation. This prepares the data path for worker thread support.

Move queue and completion processing into BlockWorker while keeping
execution on the VMM thread.

Transfer runtime resources to the worker on activation and return them
on deactivation. This prepares the data path for worker thread support.

Signed-off-by: Pierre Bertholom <pbertho@amazon.com>
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.26070% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.53%. Comparing base (1642b9d) to head (71a14b6).

Files with missing lines Patch % Lines
src/vmm/src/devices/virtio/block/virtio/device.rs 54.54% 45 Missing ⚠️
src/vmm/src/devices/virtio/block/virtio/worker.rs 78.43% 33 Missing ⚠️
src/vmm/src/devices/virtio/block/device.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           pbertho/blk-threaded-02    #6125      +/-   ##
===========================================================
- Coverage                    82.62%   82.53%   -0.09%     
===========================================================
  Files                          277      278       +1     
  Lines                        30979    31065      +86     
===========================================================
+ Hits                         25595    25639      +44     
- Misses                        5384     5426      +42     
Flag Coverage Δ
5.10-m5n.metal 82.73% <69.26%> (-0.10%) ⬇️
5.10-m6a.metal 82.09% <69.26%> (-0.10%) ⬇️
5.10-m6g.metal 79.56% <69.26%> (-0.10%) ⬇️
5.10-m6i.metal 82.74% <69.26%> (-0.10%) ⬇️
5.10-m7a.metal-48xl 82.08% <69.26%> (-0.10%) ⬇️
5.10-m7g.metal 79.56% <69.26%> (-0.09%) ⬇️
5.10-m7i.metal-24xl 82.71% <69.26%> (-0.10%) ⬇️
5.10-m7i.metal-48xl 82.71% <69.26%> (-0.11%) ⬇️
5.10-m8g.metal-24xl 79.56% <69.26%> (-0.09%) ⬇️
5.10-m8g.metal-48xl 79.56% <69.26%> (-0.09%) ⬇️
5.10-m8i.metal-48xl 82.71% <69.26%> (-0.10%) ⬇️
5.10-m8i.metal-96xl 82.71% <69.26%> (-0.10%) ⬇️
6.1-m5n.metal 82.76% <69.26%> (-0.10%) ⬇️
6.1-m6a.metal 82.11% <69.26%> (-0.11%) ⬇️
6.1-m6g.metal 79.55% <69.26%> (-0.10%) ⬇️
6.1-m6i.metal 82.76% <69.26%> (-0.10%) ⬇️
6.1-m7a.metal-48xl 82.10% <69.26%> (-0.10%) ⬇️
6.1-m7g.metal 79.56% <69.26%> (-0.09%) ⬇️
6.1-m7i.metal-24xl 82.77% <69.26%> (-0.11%) ⬇️
6.1-m7i.metal-48xl 82.77% <69.26%> (-0.10%) ⬇️
6.1-m8g.metal-24xl 79.55% <69.26%> (-0.09%) ⬇️
6.1-m8g.metal-48xl 79.56% <69.26%> (-0.09%) ⬇️
6.1-m8i.metal-48xl 82.77% <69.26%> (-0.10%) ⬇️
6.1-m8i.metal-96xl 82.78% <69.26%> (-0.10%) ⬇️
6.18-m5n.metal 82.76% <69.26%> (-0.10%) ⬇️
6.18-m6a.metal 82.11% <69.26%> (-0.10%) ⬇️
6.18-m6g.metal 79.56% <69.26%> (-0.09%) ⬇️
6.18-m6i.metal 82.76% <69.26%> (-0.10%) ⬇️
6.18-m7a.metal-48xl 82.11% <69.26%> (-0.10%) ⬇️
6.18-m7g.metal 79.56% <69.26%> (-0.09%) ⬇️
6.18-m7i.metal-24xl 82.77% <69.26%> (-0.10%) ⬇️
6.18-m7i.metal-48xl 82.77% <69.26%> (-0.11%) ⬇️
6.18-m8g.metal-24xl 79.56% <69.26%> (-0.09%) ⬇️
6.18-m8g.metal-48xl 79.56% <69.26%> (-0.09%) ⬇️
6.18-m8i.metal-48xl 82.77% <69.26%> (-0.10%) ⬇️
6.18-m8i.metal-96xl 82.77% <69.26%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant