-
Notifications
You must be signed in to change notification settings - Fork 70
fix(admin): attach usage-tracking headers to Firestore requests #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
b098751
bc5fbba
41002d9
a1f161f
8ded4d5
efdcebc
b661f13
568696a
7583452
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,9 +32,7 @@ class FirebaseUserAgentClient extends BaseClient | |
|
|
||
| @override | ||
| Future<StreamedResponse> send(BaseRequest request) { | ||
| request.headers['X-Firebase-Client'] = 'fire-admin-dart/$packageVersion'; | ||
| request.headers['X-Goog-Api-Client'] = | ||
| 'gl-dart/$dartVersion fire-admin/$packageVersion'; | ||
| request.headers.addAll(firebaseUserAgentHeaders); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this semantically different than what was there before?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, same values — just centralized into one shared constant instead of duplicated at each call site. |
||
| return _client.send(request); | ||
| } | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.