Skip to content

feat(miner): make precommit HAMT & AMT CIDs nullable#339

Draft
rvagg wants to merge 1 commit intomasterfrom
rvagg/sector-gas/nullable-hamt
Draft

feat(miner): make precommit HAMT & AMT CIDs nullable#339
rvagg wants to merge 1 commit intomasterfrom
rvagg/sector-gas/nullable-hamt

Conversation

@rvagg
Copy link
Copy Markdown
Member

@rvagg rvagg commented Jan 22, 2025

Ref: filecoin-project/builtin-actors#1605

Draft for now, for benchmarking purposes

@rvagg rvagg force-pushed the rvagg/sector-gas/nullable-hamt branch from 4b61b36 to ec17345 Compare January 22, 2025 08:28
@rvagg rvagg force-pushed the rvagg/sector-gas/nullable-hamt branch from ec17345 to 9b966f4 Compare January 22, 2025 08:30
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 22, 2025

Codecov Report

❌ Patch coverage is 0% with 172 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.39%. Comparing base (5f30872) to head (9b966f4).
⚠️ Report is 76 commits behind head on master.

Files with missing lines Patch % Lines
builtin/v16/migration/miner.go 0.00% 59 Missing ⚠️
builtin/v16/miner/cbor_gen.go 0.00% 38 Missing ⚠️
builtin/v16/miner/invariants.go 0.00% 38 Missing ⚠️
builtin/v16/migration/top.go 0.00% 33 Missing ⚠️
builtin/v16/miner/miner_state.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage    3.39%    3.39%   -0.01%     
==========================================
  Files         662      663       +1     
  Lines      177834   177956     +122     
==========================================
  Hits         6041     6041              
- Misses     169944   170066     +122     
  Partials     1849     1849              
Files with missing lines Coverage Δ
builtin/v16/miner/miner_state.go 0.00% <0.00%> (ø)
builtin/v16/migration/top.go 0.00% <0.00%> (ø)
builtin/v16/miner/cbor_gen.go 2.20% <0.00%> (-0.01%) ⬇️
builtin/v16/miner/invariants.go 0.00% <0.00%> (ø)
builtin/v16/migration/miner.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants