Skip to content

Use patched mdbook#284

Merged
jonathanpallant merged 4 commits into
mainfrom
fixing-mdbook
May 11, 2026
Merged

Use patched mdbook#284
jonathanpallant merged 4 commits into
mainfrom
fixing-mdbook

Conversation

@jonathanpallant
Copy link
Copy Markdown
Member

This uses latest mdbook 0.5.2, but with rust-lang/mdBook#2993. The binary was built for x86-64 linux and committed to the tree.

jonathanpallant/mdBook@7e285be

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 1, 2026

Deploying ferrous-systems-rust-exercises with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0f7d127
Status: ✅  Deploy successful!
Preview URL: https://cb6069ec.ferrous-systems-rust-exercises.pages.dev
Branch Preview URL: https://fixing-mdbook.ferrous-systems-rust-exercises.pages.dev

View logs

@jonathanpallant
Copy link
Copy Markdown
Member Author

Failed with:

$ ./mdbook
./mdbook: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.39' not found (required by ./mdbook)

@jonathanpallant
Copy link
Copy Markdown
Member Author

mdbook maintainers apparently have a choice of fixes for this issue (and have had for ages) and it's not clear how they are going to proceed. So I'm actually tempted to move forward with this fix so we can get something working. We'd want to do the same for the training repo.

@jonathanpallant jonathanpallant changed the title Draft: Testing mdbook fixes. Use patched mdbook May 5, 2026
Comment thread cloudflare.sh
else
./mdbook --version || curl -sSL https://github.com/rust-lang/mdBook/releases/download/v0.5.2/mdbook-v0.5.2-x86_64-unknown-linux-gnu.tar.gz | tar -xvzf -
#./mdbook --version || curl -sSL https://github.com/rust-lang/mdBook/releases/download/v0.5.2/mdbook-v0.5.2-x86_64-unknown-linux-gnu.tar.gz | tar -xvzf -
# This one carries a patch we want
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we refer to the commit/PR of the patch here? Or is it something that will soon be reverted to a released version anyway?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That info should be in the release info in that GitHub fork. I think.

@jonathanpallant jonathanpallant added this pull request to the merge queue May 11, 2026
Merged via the queue into main with commit a8474fc May 11, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants