add(bluesky): Implement unread badge for notifications and chat - #744
Open
nexxai wants to merge 1 commit into
Open
add(bluesky): Implement unread badge for notifications and chat#744nexxai wants to merge 1 commit into
nexxai wants to merge 1 commit into
Conversation
…h Twitter recipe) Mirrors twitter recipe pattern which sums AppTabBar_Notifications + DMs. Bluesky LeftNav/BottomBar renders notification count as aria-label 'N unread items' inside a[href^='/notifications'] and chat similarly inside a[href^='/messages'] (see src/view/shell/desktop/LeftNav.tsx:476 and src/view/shell/bottom-bar/BottomBarWeb.tsx:137 plus title fallback via bskyTitle '(N) ' prefix). Sums both for direct badge; handles numeric pill fallback and hasNew dot. Bump 1.1.4 -> 1.1.5.
nexxai
changed the title
nexxai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Bluesky recipe had no
Ferdium.setBadgelogic, so notifications/chat never produced a sidebar badge - unlike the Twitter recipe which sumsAppTabBar_Notifications_Link+AppTabBar_DirectMessage_Link.Fix: mirror Twitter pattern for Bluesky's
LeftNav/BottomBarWeb(src/view/shell/desktop/LeftNav.tsxandsrc/state/queries/notifications/unread.tsx). Suma[href^="/notifications"] [aria-label*="unread"]anda[href^="/messages"] [aria-label*="unread"]with numeric pill and title(N)fallbacks (src/lib/strings/headings.ts:bskyTitle).Bumped to 1.1.5 and
pnpm lint:fix && pnpm reformat-files && pnpm packagepasses (438 recipes, 0 failures).