franz-custom-website: fix click events when trapLinkClicks is enabled - #613
franz-custom-website: fix click events when trapLinkClicks is enabled#613s-ol wants to merge 1 commit into
Conversation
|
Hi @s-ol, the use case you are mentioning should not warrant for a complete suppression of this feature, however we would be happy to see the code improved. The problem described in the issue linked is about the question of whether the event should be stopped from propagating or not. Indeed, on some websites if this event is not stopped when trapLink is on, then the webpage will open in the browser anyway, which goes against what the goal of trapLink was in the first place. |
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Fully deactivates messing with
clickevents when "Open external URLs in Ferdium" is enabled. Previously Ferdium would eat all click events on<a href="http://...and<button title="http://...tags, breaking sites that override click events to provide in-page navigation.Close ferdium/ferdium-app#2028