Add an ability to change gamemode from plugins#521
Merged
Conversation
Defman
requested changes
Jan 18, 2022
| pub fn change_gamemode(&self, gamemode: Gamemode) { | ||
| self.send_packet(ChangeGameState { | ||
| reason: StateReason::ChangeGameMode, | ||
| value: gamemode as u8 as f32, |
Member
There was a problem hiding this comment.
Can we change the protocol to take Gamemode and implement write on game mode?
Contributor
Author
There was a problem hiding this comment.
ChangeGameState requires it to be f64, so I did it in a different way.
Defman
reviewed
Jan 19, 2022
| }); | ||
| } | ||
| for (entity, flying) in fly_changes { | ||
| if flying { |
Member
There was a problem hiding this comment.
This if statement is redundant, just create CreativeFlyingEvent with the value of flying?
Defman
approved these changes
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an ability to change gamemode from plugins
Status
Description
Adds GamemodeEvent, InstabreakChangeEvent, FlyingAbilityChangeEvent, BuildingAbilityChangeEvent, and InvulnerabilityChangeEvent. This code was taken from #487 (I had to implement this for /gamemode command), but I think this change deserves a separate PR.
Related issues
Checklist
cargo fmt,cargo clippy --all-targets,cargo build --releaseandcargo testand fixed any generated errors!Note: if you locally don't get any errors, but GitHub Actions fails (especially at
clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.