Combine Google Fonts into a single preconnected request#36
Open
julioalucero wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FR-744: Redundant Google Fonts requests
Link to Jira
FR-744: Redundant Google Fonts requests
PR description
The styleguide fired two separate render-blocking Google Fonts requests via @import inside the shared SCSS. That runs on every consumer, can't be deduped, and can't be preconnected.
@import url()fromvendor/.../2-quarks/_typography.scss; font loading now belongs to the consuming app.@importsfrom the compiledstatic/styleguide.cssand.min.css.preconnecthints + one combined<link>(both families in a single request) to index.html for the demo page.PR related: https://github.com/ombulabs/fastruby.io/pull/1153
QA steps
index.html, DevTools => Network, filtercss, should be onecss2request, not two.OxygenandSource Code Prostill render correctly.Notes