Skip to content

refactor(location): simplify locale access#3809

Merged
xDivisionByZerox merged 3 commits intonextfrom
refactor/location/centralize-locale-access
Apr 18, 2026
Merged

refactor(location): simplify locale access#3809
xDivisionByZerox merged 3 commits intonextfrom
refactor/location/centralize-locale-access

Conversation

@ST-DDT
Copy link
Copy Markdown
Member

@ST-DDT ST-DDT commented Apr 15, 2026

Based on #3189 (review)


Changes the location module implementation:

  • Reduces the locale data lookups
  • Reduce code duplication
  • Standardize locale accessing methods

@ST-DDT ST-DDT added this to the vAnytime milestone Apr 15, 2026
@ST-DDT ST-DDT self-assigned this Apr 15, 2026
@ST-DDT ST-DDT requested a review from a team as a code owner April 15, 2026 21:20
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module labels Apr 15, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 15, 2026

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 6168207
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/69e37427905547000811bc74
😎 Deploy Preview https://deploy-preview-3809.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.90%. Comparing base (325e402) to head (6168207).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3809   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         896      896           
  Lines        3100     3100           
  Branches      572      572           
=======================================
  Hits         3066     3066           
  Misses         30       30           
  Partials        4        4           
Files with missing lines Coverage Δ
src/modules/location/index.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ST-DDT ST-DDT requested a review from a team April 15, 2026 21:25
@xDivisionByZerox xDivisionByZerox modified the milestones: vAnytime, v10.x Apr 18, 2026
@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Apr 18, 2026
Merged via the queue into next with commit f45c508 Apr 18, 2026
36 of 37 checks passed
@xDivisionByZerox xDivisionByZerox deleted the refactor/location/centralize-locale-access branch April 18, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants