chore: import types from the source file directly#3805
Merged
xDivisionByZerox merged 1 commit intonextfrom Apr 18, 2026
Merged
Conversation
ST-DDT
added
c: chore
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3805 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 894 894
Lines 3086 3086
Branches 564 564
=======================================
Hits 3052 3052
Misses 30 30
Partials 4 4
🚀 New features to boost your workflow:
|
Shinigami92
approved these changes
Apr 13, 2026
xDivisionByZerox
approved these changes
Apr 18, 2026
Member
xDivisionByZerox
left a comment
xDivisionByZerox
left a comment
There was a problem hiding this comment.
Is there a linter rule to restrict the importing from the index.ts file for all other files by any change? I can see this slipping in again in later refactors due to IDEs usually preferring to pick the shortest import path that is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import directly from the source file to avoid automatically adding new imports to it, causing side effects.