Skip to content

test(person): cleanup tests#3804

Merged
xDivisionByZerox merged 4 commits intonextfrom
test/person/cleanup
Apr 18, 2026
Merged

test(person): cleanup tests#3804
xDivisionByZerox merged 4 commits intonextfrom
test/person/cleanup

Conversation

@ST-DDT
Copy link
Copy Markdown
Member

@ST-DDT ST-DDT commented Apr 12, 2026

Simplifies and standardizes the person tests.
This reduces the diff for #3748 and #3189.

@ST-DDT ST-DDT added this to the vAnytime milestone Apr 12, 2026
@ST-DDT ST-DDT requested review from a team April 12, 2026 16:24
@ST-DDT ST-DDT self-assigned this Apr 12, 2026
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test m: person Something is referring to the person module labels Apr 12, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 12, 2026

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 5d08b68
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/69dbc91d5f07f00009f6ada4
😎 Deploy Preview https://deploy-preview-3804.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (bf58838) to head (5d08b68).
⚠️ Report is 10 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3804   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files         894      894           
  Lines        3086     3086           
  Branches      564      548   -16     
=======================================
  Hits         3052     3052           
  Misses         30       30           
  Partials        4        4           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ST-DDT ST-DDT requested review from a team April 15, 2026 22:21
@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Apr 18, 2026
Merged via the queue into next with commit 9997a48 Apr 18, 2026
23 checks passed
@xDivisionByZerox xDivisionByZerox deleted the test/person/cleanup branch April 18, 2026 14:23
@xDivisionByZerox xDivisionByZerox modified the milestones: vAnytime, v10.x Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: test m: person Something is referring to the person module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants