docs: add sponsors#3674
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3674 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 899 899
Lines 3113 3113
Branches 574 574
=======================================
Hits 3079 3079
Misses 30 30
Partials 4 4 🚀 New features to boost your workflow:
|
|
Team Decision: @Shinigami92 will try out the https://graphql-docs-v2.opencollective.com/access and dynamically query in vitepress clientside the active sponsors and cache that for ~1 month clientside, so the limit of 10r/min are not exceeded |
Shinigami92
force-pushed
the
docs-add-sponsors
branch
from
79afcb0 to
dda8e09
Compare
|
I don't see anything new on the deploy preview? |
lower right corner 
|
Shinigami92
force-pushed
the
docs-add-sponsors
branch
from
40c9013 to
d2345af
Compare
|
In case this doesn't load, we should handle it more gracefully.
Also the initial load looks different than later updates:
(fixes itself on window resize) |
Shinigami92
force-pushed
the
docs-add-sponsors
branch
from
d2345af to
dc5aca2
Compare
xDivisionByZerox
left a comment
xDivisionByZerox
left a comment
There was a problem hiding this comment.
Looks good enough for now. We can iterate in the future if we desire to do so.
| .map((backer) => ({ | ||
| name: backer.account.name ?? backer.account.slug, | ||
| img: backer.account.imageUrl ?? '', | ||
| url: `https://opencollective.com/${backer.account.slug}`, | ||
| })) | ||
| .slice(0, 10) || [] |
There was a problem hiding this comment.
Please filter/reduce the data before writing it to local storage.
There was a problem hiding this comment.
I stored the full data on purpose, so if we need to adjust data or want to display more or less later, we don't have a breaking change but just can access the cached data as is.
There was a problem hiding this comment.
I don't expect the used data to change. But 🤷
Shinigami92
force-pushed
the
docs-add-sponsors
branch
from
dc5aca2 to
039cfc5
Compare
| backers, | ||
| }; | ||
| } catch { | ||
| // Silently ignore fetch errors; the section will hide itself when empty. |
There was a problem hiding this comment.
Maybe cache the failure, to avoid using up all api limits.
ST-DDT
left a comment
ST-DDT
left a comment
There was a problem hiding this comment.
Technically ok, but not really my preference to have.
ST-DDT
added
p: 1-normal
4 participants
Adding a sponsoring section to honor partners.
It is not final yet in which groups we split them.