refactor(locale): fix en_GB postcode patterns#3234
Draft
ST-DDT wants to merge 2 commits intorefactor/location/zipCode/fakefrom
Draft
refactor(locale): fix en_GB postcode patterns#3234ST-DDT wants to merge 2 commits intorefactor/location/zipCode/fakefrom
ST-DDT wants to merge 2 commits intorefactor/location/zipCode/fakefrom
Conversation
10 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor/location/zipCode/fake #3234 +/- ##
===============================================================
Coverage 99.96% 99.96%
===============================================================
Files 2805 2805
Lines 217143 217143
Branches 969 969
===============================================================
+ Hits 217066 217068 +2
+ Misses 77 75 -2
🚀 New features to boost your workflow:
|
6600184 to
e276128
Compare
e276128 to
35398f2
Compare
…_GB/location/zipcode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third and final part of #2390
Related to #3235
Blocked by #3223 and #3233
Fixes the pattern for
en_GBusing the patterns from the second page of this document (linked in the original issue)Workaround until this is merged:
(can also be used in browser console on our website)