feat: introduce FakerCore

[ST-DDT]

First part of the standalone module function feature #2667

• Proposal: Design for standalone module functions #2667

Overview

1. Introduce FakerCore feat: introduce FakerCore #2838
2. De-proxy locale access feat: de-proxy locale access #3189
3. De-class config function feat: standalone module functions #3748 (seed, setDefaultRefDate, ...)
4. De-module functions feat: standalone module functions #3748 (airline, ...)

Description

Create the fakerCore container object.

[netlify]

✅ Deploy Preview for fakerjs ready!

Name	Link
🔨 Latest commit	e659674
🔍 Latest deploy log	https://app.netlify.com/sites/fakerjs/deploys/671018639e657d00089dc08d
😎 Deploy Preview	https://deploy-preview-2838.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Shinigami92]

I know the PR is still in draft but I would like to provide some early-feedback

1. I think the refDate should still be named something like default or fallback or base, so the intent is more clear and there might be no variable naming conflict when using an option's refDate + the ...RefDate
2. I suggest to not do something like super({ fakerCore: fakerCore ?? { locale, randomizer, config: {} } }) but only pass the locale and randomizer so the config get's set like every other method call to a default internally. Or is there something special about that I currently overlook? 👀

[ST-DDT]

1. Done
2. Changed slightly to improve readability.

[ST-DDT]

Does anybody know why this test is failing with that particular error message?

❯ test/simple-faker.spec.ts > simpleFaker > should not log anything on startup
→ Unexpected token ','

It seems to happen only with vitest/CJS.

[Shinigami92]

Does anybody know why this test is failing with that particular error message?

❯ test/simple-faker.spec.ts > simpleFaker > should not log anything on startup
→ Unexpected token ','

It seems to happen only with vitest/CJS.

If I set minify: false in tsup.config.ts everything runs fine. Please report a bug-issue to https://github.com/egoist/tsup

Or it is related to https://github.com/egoist/tsup/issues/1091

[ST-DDT]

The error is caused by this part:

_class.prototype.__init23.call(this);,this.definitions=_chunkWAQHUEHTcjs.d.call(void 0, this.rawDefinitions)
                                     ^

Which is equivalent to this source code:

faker/src/faker.ts

Lines 195 to 197 in e4da2f5

	super({ fakerCore });
	this.definitions = createLocaleProxy(this.rawDefinitions);

[ST-DDT]

I created an issue in tsup with a minimal reproduction:

• Bug when bundling commonjs when there is code before super() egoist/tsup#1124

And it has reeeaaally specific conditions, check the issue for more details.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (d17c0f1) to head (0c2e3de).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2838   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files         893      894    +1     
  Lines        3082     3087    +5     
  Branches      546      548    +2     
=======================================
+ Hits         3048     3053    +5     
  Misses         30       30           
  Partials        4        4           

Files with missing lines	Coverage Δ
src/core.ts	100.00% <100.00%> (ø)
src/faker.ts	100.00% <100.00%> (ø)
src/modules/helpers/eval.ts	95.65% <100.00%> (ø)
src/modules/number/index.ts	100.00% <100.00%> (ø)
src/modules/person/index.ts	94.11% <100.00%> (+0.08%)	⬆️
src/simple-faker.ts	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Shinigami92]

LGTM

[matthewmayer]

see my comment at #2667 (comment) - would it make sense to delay merging this?

[ST-DDT]

is there a reason why it is still in draft? have you anything planned to change in this PR?

Only discussions regarding names, behaviour, API and PR contents.

[xDivisionByZerox]

Team Decision

We take this regardless of whether we also take the standalone modules PR (#3748)

---

@ST-DDT Please rebase/merge this branch against origin/next.