Repository navigation
fix(build): Pin macOS builds to Homebrew OpenSSL 3 - #19945
Merged
meta-codesync[bot] merged 1 commit intoOct 30, 2026
Merged
Conversation
Homebrew's unversioned `openssl` formula has pointed at OpenSSL 4 since
2026-09-27, and that formula is no longer keg-only, so OpenSSL 4 headers
and libraries are linked under $(brew --prefix). The macos-15 runner
image 20261028.0489.1 ships it, and since it rolled out every macOS CI
build fails while installing dependencies: Folly at FB_OS_VERSION
(v2026.09.07.00) reads ASN1_STRING fields directly and assigns
X509_get_subject_name() to a non-const pointer, both of which OpenSSL 4
removed:
folly/io/async/ssl/OpenSSLUtils.cpp:126:62: error: member access
into incomplete type 'ASN1_OCTET_STRING' (aka 'asn1_string_st')
Moving FB_OS_VERSION forward is not enough on its own: Folly supports
OpenSSL 4 from v2026.10.12.00, but the gRPC 1.48.1 that Velox bundles
for its tests fails the same way (src/core/tsi/ssl_transport_security.cc).
setup-macos.sh now installs openssl@3 and exports OPENSSL_ROOT_DIR for
it, and cmake_install passes it as a cache variable as well, because
fbthrift ships its own FindOpenSSL that ignores the environment and
otherwise asks Homebrew for its default openssl. The macOS and pyvelox
workflows carry OPENSSL_ROOT_DIR into their later steps. CMakeLists.txt
defaults a macOS configure to Homebrew's OpenSSL 3 when no OpenSSL root
was chosen, so a plain `make` in a fresh shell keeps matching the
dependencies, and puts the OpenSSL include directory ahead of
$(brew --prefix)/include, which Folly::folly_deps exports and where
OpenSSL 4's headers now live. Setting OPENSSL_ROOT_DIR yourself still
wins.
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
pedroerp
approved these changes
Oct 30, 2026
pedroerp
left a comment
pedroerp
left a comment
Contributor
There was a problem hiding this comment.
Thank you. Let's wait until the job finishes, then I'll get it merged.
Selective Build Plan
Selective build plan |
Contributor
|
@pedroerp has imported this pull request. If you are a Meta employee, you can view this in D128692789. |
pedroerp
added
the
ready-to-merge
meta-codesync
Bot
merged commit Oct 30, 2026
8a97c9e
into
facebookincubator:main
73 of 74 checks passed
tinadu1018
added a commit
to tinadu1018/velox
that referenced
this pull request
Oct 30, 2026
## Summary Merge upstream main at 8f6c946 into the FBOS upgrade branch. Align the signature-comparison baseline with upstream changes already present in CI's merged checkout. Keep upstream's OpenSSL 3 selection and targeted VectorIndex GoogleMock linkage. Remove our superseded OpenSSL selection block, duplicate setup export, and broad aggregates-test GoogleMock dependency. The remaining PR diff contains only the dependency upgrade and its FBThrift/xxhash compatibility fixes. ## Prompting Intent Fix the reported Fuzzer Jobs failures reasonably without pipeline, test-selection, coverage, or unnecessary component changes. The engineer explicitly approved a normal merge of upstream main, without history rewriting or force-pushing, and requested inspection of macOS 15 Debug. ## Linked Sources - Upgrade PR: facebookincubator#19909 - Failed Fuzzer Jobs: https://github.com/facebookincubator/velox/actions/runs/41132095439 - Baseline and contender provenance: https://github.com/facebookincubator/velox/actions/runs/41132095439/job/124325288109 - Upstream timezone signature change: facebookincubator#19632 - Upstream collect_set companion: facebookincubator#19894 - Upstream OpenSSL fix: facebookincubator#19945 - Upstream targeted GoogleMock fix: facebookincubator#19942 - Current macOS Debug job: https://github.com/facebookincubator/velox/actions/runs/41132095473/job/124331293031 - Presto mismatch: https://github.com/facebookincubator/velox/actions/runs/41132095439/job/124333376983 ## Rationale CI compared signatures saved for merge base 5df6f9b with a contender containing upstream commits c853cce and b8e1609. Those upstream commits intentionally removed at_timezone_convert and added collect_set_merge_extract. Do not restore removed functions, filter signatures, modify skip lists, or replace the failing jobs. Updating the branch baseline avoids attributing inherited upstream changes to this dependency upgrade. Upstream now supplies the macOS build fixes, so preserve its implementation instead of keeping duplicate or broader local workarounds. Retain the version/checksum updates and the proven compiler-export and xxhash-target compatibility fixes. No independent fix for the saved Presto value/null mismatch is claimed by this merge. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fdd7945e-1c8f-4e79-ac56-0fbeeedaffbd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew's unversioned
opensslformula has pointed at OpenSSL 4 since 2026-09-27 (Homebrew/homebrew-core 9a12b94a88), and that formula is no longer keg-only, so OpenSSL 4 headers and libraries are linked under$(brew --prefix). The macos-15 runner image 20261028.0489.1 ships it, and since it rolled out everymacOS Buildrun fails while installing dependencies, because Folly atFB_OS_VERSION(v2026.09.07.00) readsASN1_STRINGfields directly and assignsX509_get_subject_name()to a non-const pointer, both of which OpenSSL 4 removed:Moving
FB_OS_VERSIONforward is not enough on its own: Folly supports OpenSSL 4 from v2026.10.12.00 (wangle from v2026.09.21.00), but the gRPC 1.48.1 that Velox bundles for its tests fails the same way (src/core/tsi/ssl_transport_security.cc; fixed upstream only in gRPC 1.85.0), as the FBOS bump in #19909 shows (run 41084854386).scripts/setup-macos.shinstallsopenssl@3and exportsOPENSSL_ROOT_DIRfor it, so every dependency it builds uses OpenSSL 3. A caller that already setOPENSSL_ROOT_DIRkeeps its choice.cmake_installalso passesOPENSSL_ROOT_DIRas a cache variable. fbthrift ships its ownFindOpenSSL.cmakethat ignores the environment and otherwise runsbrew --prefix openssl, which now resolves to OpenSSL 4.OPENSSL_ROOT_DIRinto their later steps, which run in a new shell.CMakeLists.txtdefaults a macOS configure to Homebrew's OpenSSL 3 when no OpenSSL root was chosen (and warns whenopenssl@3is missing), so a plainmakein a fresh shell keeps matching the dependencies built by the script.Folly::folly_depsexports$(brew --prefix)/includeahead of it, where OpenSSL 4's headers now live, so Velox sources that include<openssl/*.h>would otherwise compile against OpenSSL 4 headers while linking OpenSSL 3.This can be reverted once the pinned Folly and gRPC releases both build against OpenSSL 4.
Related: #19936 and #19257 pin
openssl@3the same way. This PR additionally covers fbthrift, whose ownFindOpenSSL.cmakeignoresOPENSSL_ROOT_DIRfrom the environment (the macOS run of #19936, 41096009930, configures fbthrift against/opt/homebrew/opt/openssl@4while folly, fizz, wangle and mvfst useopenssl@3), and the include order on Velox's own compile lines.Note: with dependencies building again, the macOS Build step still fails on
mainwithVectorIndexBuildTest.cpp:17:10: fatal error: 'gmock/gmock.h' file not found(from #19886); #19942 fixes that, so the macOS job here can only turn green once it has landed andmainis merged into this branch.