upgrading tokio to 1.52.1#64
Conversation
Summary: X-link: facebookincubator/below#8278 X-link: https://github.com/facebookexperimental/dapper/pull/1 X-link: meta-pytorch/monarch#3495 Upgrading `tokio` from `1.50.0` to `1.52.1`. - All downstream consumers checked with arc rust-check — 0 errors. Reviewed By: dtolnay Differential Revision: D101580193
meta-cla
Bot
added
the
CLA Signed
|
@zbowling has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101580193. |
There was a problem hiding this comment.
Pull request overview
Upgrades the Tokio dependency across workspace crates from 1.50.0 to 1.52.1.
Changes:
- Bump
tokioto1.52.1inhermit-cli. - Bump
tokioto1.52.1indetcore. - Bump
tokioto1.52.1indetcore-testutils.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hermit-cli/Cargo.toml | Updates Tokio dependency version for the CLI crate. |
| detcore/Cargo.toml | Updates Tokio dependency version for the core crate. |
| detcore/tests/testutils/Cargo.toml | Updates Tokio dependency version for test utilities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| shell-words = "1.1.1" | ||
| tempfile = "3.27.0" | ||
| tokio = { version = "1.50.0", features = ["full", "test-util", "tracing"] } | ||
| tokio = { version = "1.52.1", features = ["full", "test-util", "tracing"] } |
There was a problem hiding this comment.
Since hermit-cli/Cargo.lock is checked in, consider regenerating it as part of this Tokio bump so the lockfile reflects the new tokio requirement. Otherwise cargo build --locked (or any workflow that relies on the committed lockfile) can fail because the current lockfile pins tokio to an older version.
Summary:
X-link: facebookincubator/below#8278
X-link: https://github.com/facebookexperimental/dapper/pull/1
X-link: meta-pytorch/monarch#3495
Upgrading
tokiofrom1.50.0to1.52.1.Reviewed By: dtolnay
Differential Revision: D101580193