Clean up per-test DB paths after unit tests to avoid ENOSPC#14622
Open
xingbowang wants to merge 1 commit intofacebook:mainfrom
Open
Clean up per-test DB paths after unit tests to avoid ENOSPC#14622xingbowang wants to merge 1 commit intofacebook:mainfrom
xingbowang wants to merge 1 commit intofacebook:mainfrom
Conversation
|
| Check | Count |
|---|---|
concurrency-mt-unsafe |
1 |
| Total | 1 |
Details
test_util/testharness.cc (1 warning(s))
test_util/testharness.cc:122:9: warning: function is not thread safe [concurrency-mt-unsafe]
|
@xingbowang has imported this pull request. If you are a Meta employee, you can view this in D101068798. |
1 similar comment
|
@xingbowang has imported this pull request. If you are a Meta employee, you can view this in D101068798. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When we migrated from one test one process model to sharding model, we didn't add db folder cleanup. This causes db folders to pile up in unit test. Add db folder clean up after each test completion on success. This keep the disk utilization low.
PerThreadDBPath()after each passing test so sharded unit-test runs do not accumulate leftover DB directoriesKEEP_DBis set or the test fails, while still resetting SyncPoint state between testsmake checkdisk-usage diagnostics that report the largest per-test temp directories and DB-like directories on failureTest Plan
python3 build_tools/make_check_dbdir_report_test.pymake -j14 testutil_test/usr/local/bin/timeout 60 ./testutil_test --gtest_filter="TestUtil.CleanupRegisteredPerTestPathsRemovesDirectory:TestUtil.CleanupRegisteredPerTestPathsRemovesFile"