Fix std::terminate in LoadTableHandlersHelper#14603
Fix std::terminate in LoadTableHandlersHelper#14603Ignition wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @Ignition! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
LoadTableHandlersHelper spawns background threads into a std::vector using emplace_back in a loop. If emplace_back throws (e.g. std::bad_alloc from vector reallocation, or std::system_error from pthread_create failing under resource limits), stack unwinding destroys the vector, which calls ~thread() on already-started but unjoined threads. Per the C++ standard, destroying a joinable std::thread calls std::terminate, crashing the process unconditionally. Fix by switching from port::Thread (std::thread) to std::jthread, which auto-joins on destruction. This guarantees that if an exception propagates (e.g. std::bad_alloc from a per-query memory limit), all running threads are safely joined during stack unwinding rather than triggering std::terminate. Additionally catch std::system_error from thread creation to degrade gracefully to fewer threads rather than aborting. Also add an early return when files_meta is empty to avoid unnecessary work.
Ignition
force-pushed
the
fix_unintended_terminate
branch
from
d4ae50a to
2b8d40e
Compare
2 participants
LoadTableHandlersHelper spawns background threads into a std::vector using emplace_back in a loop. If emplace_back throws (e.g. std::bad_alloc from vector reallocation, or std::system_error from pthread_create failing under resource limits), stack unwinding destroys the vector, which calls ~thread() on already-started but unjoined threads. Per the C++ standard, destroying a joinable std::thread calls std::terminate, crashing the process unconditionally.
Fix by switching from port::Thread (std::thread) to std::jthread, which auto-joins on destruction. This guarantees that if an exception propagates (e.g. std::bad_alloc from a per-query memory limit), all running threads are safely joined during stack unwinding rather than triggering std::terminate. Additionally catch std::system_error from thread creation to degrade gracefully to fewer threads rather than aborting. Also add an early return when files_meta is empty to avoid unnecessary work.
Fixes #13303