Clean up leaked remote compaction outputs in crash tests#14592
Open
xingbowang wants to merge 3 commits intofacebook:mainfrom
Open
Clean up leaked remote compaction outputs in crash tests#14592xingbowang wants to merge 3 commits intofacebook:mainfrom
xingbowang wants to merge 3 commits intofacebook:mainfrom
Conversation
Remote compaction jobs write per-job tmp_output_* directories under the crash-test DB. Those directories need to stay around while a live db_stress process is exercising resumable compaction, but terminal OpenAndCompact() failures were leaving them behind and long crash-test runs could eventually fill /dev/shm. Clean up tmp_output_* directories once a remote compaction job reaches a terminal failure, and prune any stale tmp_output_* directories between crash-test iterations so leaked state from a killed child process does not accumulate across the full run series. Also add focused Python coverage for the stale-directory cleanup helper. Refs T263917962.
✅ clang-tidy: No findings on changed linesCompleted in 0.0s. |
|
@xingbowang has imported this pull request. If you are a Meta employee, you can view this in D100203332. |
# Conflicts: # tools/db_crashtest.py # tools/db_crashtest_test.py
|
@xingbowang has imported this pull request. If you are a Meta employee, you can view this in D100203332. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote compaction jobs write per-job
tmp_output_*directories under the crash-test DB. Those directories need to stay around while a livedb_stressprocess is exercising resumable compaction, but terminalOpenAndCompact()failures were leaving them behind and long crash-test runs could eventually fill/dev/shm.Changes
db_stress_common.ccDestroyOutputDirectory()fromCleanupOutputDirectory()so the low-level destroy (with fault-injection disable/re-enable) can be called independently.DestroyOutputDirectory()on terminalOpenAndCompact()failures so the per-job output directory is cleaned up immediately instead of being leaked.db_crashtest.pycleanup_stale_remote_compaction_outputs(dbname)— between crash-test iterations and before the final verification run, prune any leftovertmp_output_*directories that a killed child process may have leaked.db_crashtest_test.pytmp_output_*entries and leaves other DB contents (.sstfiles,.backup*dirs) untouched.Refs T263917962.