Skip to content

Fix unused parameter warning in ExtractUncompressedSize#14564

Open
namsic wants to merge 1 commit intofacebook:mainfrom
namsic:14309
Open

Fix unused parameter warning in ExtractUncompressedSize#14564
namsic wants to merge 1 commit intofacebook:mainfrom
namsic:14309

Conversation

@namsic
Copy link
Copy Markdown

@namsic namsic commented Apr 3, 2026

Problem

When SNAPPY is not defined, ExtractUncompressedSize in BuiltinDecompressorV2SnappyOnly does not use the args parameter, causing a -Werror=unused-parameter compilation error:

  CC       util/compression.o
util/compression.cc: In member function ‘virtual rocksdb::Status rocksdb::{anonymous}::BuiltinDecompressorV2SnappyOnly::ExtractUncompressedSize(rocksdb::Decompressor::Args&)’:
util/compression.cc:1541:40: error: unused parameter ‘args’ [-Werror=unused-parameter]
 1541 |   Status ExtractUncompressedSize(Args& args) override {
      |                                  ~~~~~~^~~~
cc1plus: all warnings being treated as errors
make: *** [Makefile:2590: util/compression.o] Error 1

Fix

Add [[maybe_unused]] to the args parameter to suppress the warning when SNAPPY is not defined.

@meta-cla meta-cla Bot added the CLA Signed label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails without Snappy

1 participant