Typegen: Add intersection variant, and wrap unions and intersections in parentheses when they have more than one member#3809
Closed
MaartenStaa wants to merge 1 commit intofacebook:mainfrom
Conversation
…heses when they have more than one member.
Contributor
|
@rbalicki2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
I think this one is no longer required as #3280 was restructured to not use intersections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to start split #3280 into smaller parts. Not crazy about how many parentheses are being added as a result in the test fixtures. I could add a few more changes to reduce these when not needed. Thoughts?
@rbalicki2