Sort object members in typegen#3808
Closed
MaartenStaa wants to merge 2 commits intofacebook:mainfrom
Closed
Conversation
Contributor
|
@rbalicki2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Love it! Thank you for doing this!!! This is going to make changes in the future so much easier to land. I might make some minor changes on my end — using descriptive constants in sort_props, and potentially avoiding a clone by sorting when the AST::[In]ExactObject is created, but besides those nits, this looks great!! Can you also put up a diff to sort the items in union and intersection types, and to sort FragmentReference types? I think these ordering diffs + adding parentheses around union and intersection types can all land at once, and be rolled out slowly (but as a unit) internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to start split #3280 into smaller parts. When writing objects (whether exact or inexact) in typegen, sort the object's members by name. The used sorting is a bit subjective, so I'm open to suggestions.
@rbalicki2