upgrading tokio to 1.52.1#3186
Closed
zbowling wants to merge 1 commit into
Closed
Conversation
Summary: X-link: https://github.com/facebookexperimental/unigraph/pull/11 X-link: facebookexperimental/reverie#36 X-link: facebookincubator/reindeer#103 X-link: facebookincubator/below#8278 X-link: https://github.com/facebookexperimental/dapper/pull/1 X-link: meta-pytorch/monarch#3495 Upgrading `tokio` from `1.50.0` to `1.52.1`. - All downstream consumers checked with arc rust-check — 0 errors. Reviewed By: dtolnay Differential Revision: D101580193
Contributor
|
@zbowling has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101580193. |
There was a problem hiding this comment.
Pull request overview
Upgrades the tokio dependency used by the pyrefly crate, updating the workspace lockfile accordingly.
Changes:
- Bump
tokiofrom1.50.0to1.52.1inpyrefly/Cargo.toml. - Refresh
Cargo.lockto the resolved dependency set (includingtokio-macrosandsocket2transitive updates).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pyrefly/Cargo.toml |
Updates the direct tokio dependency version for the pyrefly crate. |
Cargo.lock |
Captures the resulting dependency resolution changes from the tokio upgrade. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
This PR seems to be redundant as the diff you posted internally already upgraded Tokio for Pyrefly as well. Closing this out. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookexperimental/unigraph/pull/11
X-link: facebookexperimental/reverie#36
X-link: facebookincubator/reindeer#103
X-link: facebookincubator/below#8278
X-link: https://github.com/facebookexperimental/dapper/pull/1
X-link: meta-pytorch/monarch#3495
Upgrading
tokiofrom1.50.0to1.52.1.Reviewed By: dtolnay
Differential Revision: D101580193