Fix OOB read in .gnu_debuglink parsing due to unbounded strlen#2634
Open
metsw24-max wants to merge 1 commit intofacebook:mainfrom
Open
Fix OOB read in .gnu_debuglink parsing due to unbounded strlen#2634metsw24-max wants to merge 1 commit intofacebook:mainfrom
metsw24-max wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ELF debuglink parsing logic used strlen() on raw section data without verifying the presence of a null terminator within section bounds.
This results in an out-of-bounds read when processing malformed ELF files where the .gnu_debuglink section is not null-terminated.
-Replaces strlen() with bounded memchr()-based parsing
-Validates that a null terminator exists within section bounds
-Avoids copying beyond validated length and explicitly terminate output buffer