Look for libblake3 and link to it when found#2605
Open
CSharperMantle wants to merge 1 commit intofacebook:mainfrom
Open
Look for libblake3 and link to it when found#2605CSharperMantle wants to merge 1 commit intofacebook:mainfrom
CSharperMantle wants to merge 1 commit intofacebook:mainfrom
Conversation
Currently, folly only checks for the existence of <blake3.h> to decide whether to use libblake3 or not. Even on systems with <blake3.h> installed, the appropriate linker flags is still needed to actually link it. Fixes: facebook#2552
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, folly decides whether to use libblake3 symbols solely depending on the existence of
<blake3.h>:folly/folly/hash/UniqueHashKey.h
Line 66 in 5ae1dd9
... but without any explicit linking directives in the CMake files. Thus, on systems where
<blake3.h>exists, consumers of folly would fail to link.This PR introduces optional linking directives to libblake3.
Fixes #2552.