Fix aarch64 duplicate symbol errors in libfolly#2562
Closed
ptarjan wants to merge 1 commit into
Closed
Conversation
The -use variants of memcpy_aarch64 and memset_aarch64 were being included in the monolithic libfolly.so, causing duplicate symbol errors because they compile the same assembly files as the non-use variants. Add EXCLUDE_FROM_MONOLITH to memcpy_aarch64-use and memset_aarch64-use to match the pattern used for memcpy-use and memset-use in the main folly/CMakeLists.txt. The -use variants are meant for explicit opt-in to override libc memcpy/memset, not for inclusion in the main library. Fixes: https://github.com/facebook/folly/issues/XXXXX
ptarjan
pushed a commit
to ptarjan/nixpkgs
that referenced
this pull request
Jan 20, 2026
Add EXCLUDE_FROM_MONOLITH to memcpy_aarch64-use and memset_aarch64-use targets to prevent duplicate symbol errors when building libfolly.so. The "Add granular CMake build targets" commit (2026.01.18) introduced both -use and non-use variants from the same source files, causing linker errors on aarch64-linux. facebook/folly#2562
Contributor
Author
|
Same result as #2561 different implementation |
ptarjan
pushed a commit
to ptarjan/nixpkgs
that referenced
this pull request
Jan 22, 2026
folly: remove obsolete fix-__type_pack_element.patch folly: disable flaky largeRetries test This test times out under resource constraints. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> folly: disable flaky UseAfterFork test folly: fix aarch64-linux duplicate symbol errors Add EXCLUDE_FROM_MONOLITH to memcpy_aarch64-use and memset_aarch64-use targets to prevent duplicate symbol errors when building libfolly.so. The "Add granular CMake build targets" commit (2026.01.18) introduced both -use and non-use variants from the same source files, causing linker errors on aarch64-linux. facebook/folly#2562
ptarjan
pushed a commit
to ptarjan/nixpkgs
that referenced
this pull request
Jan 22, 2026
folly: remove obsolete fix-__type_pack_element.patch folly: disable flaky largeRetries test This test times out under resource constraints. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> folly: disable flaky UseAfterFork test folly: fix aarch64-linux duplicate symbol errors Add EXCLUDE_FROM_MONOLITH to memcpy_aarch64-use and memset_aarch64-use targets to prevent duplicate symbol errors when building libfolly.so. The "Add granular CMake build targets" commit (2026.01.18) introduced both -use and non-use variants from the same source files, causing linker errors on aarch64-linux. facebook/folly#2562
|
I tried patching this into latest v2026.03.02.00 for Homebrew's arm64 Linux build and noticed that it doesn't work when building shared libraries: I worked around this by adding |
|
@yfeldblum merged this pull request in ae5bbaf. |
meta-codesync Bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Mar 6, 2026
Summary: The -use variants of memcpy_aarch64 and memset_aarch64 were being included in the monolithic libfolly.so, causing duplicate symbol errors because they compile the same assembly files as the non-use variants. Add EXCLUDE_FROM_MONOLITH to memcpy_aarch64-use and memset_aarch64-use to match the pattern used for memcpy-use and memset-use in the main folly/CMakeLists.txt. The -use variants are meant for explicit opt-in to override libc memcpy/memset, not for inclusion in the main library. X-link: facebook/folly#2562 Reviewed By: afrind Differential Revision: D95509547 Pulled By: yfeldblum fbshipit-source-id: d999b44c23685d5371f83fcc65ede573a28afb9e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The -use variants of memcpy_aarch64 and memset_aarch64 were being included in the monolithic libfolly.so, causing duplicate symbol errors because they compile the same assembly files as the non-use variants.
Add EXCLUDE_FROM_MONOLITH to memcpy_aarch64-use and memset_aarch64-use to match the pattern used for memcpy-use and memset-use in the main folly/CMakeLists.txt. The -use variants are meant for explicit opt-in to override libc memcpy/memset, not for inclusion in the main library.