fix(theme): remove superfluous ARIA region from SkipToContent link#11938
fix(theme): remove superfluous ARIA region from SkipToContent link#11938JoshuaM195 wants to merge 1 commit intofacebook:mainfrom
Conversation
Removes the `<div role="region">` wrapper around the skip-to-content link. Screen readers were announcing the element twice: once for the region landmark and once for the link itself, e.g. "skip to main content region, link, skip to main content". The ref used for page-transition focus management is moved directly onto the `<a>` element, eliminating the need for the wrapper div entirely. Fixes facebook#8418
|
Hi @JoshuaM195! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Removes the
<div role="region">wrapper around the skip-to-content link. Screen readers were announcing the element twice: once for the region landmark and once for the link itself, e.g. "skip to main content region, link, skip to main content".The ref used for page-transition focus management is moved directly onto the
<a>element, eliminating the need for the wrapper div entirely.Fixes #8418
Pre-flight checklist
Motivation
Fixes #8418
The
SkipToContentLinkcomponent wrapped the skip link in a<div role="region" aria-label="Skip to main content">. This caused screen readers to announce the element twice. Once for the landmark region and once for the link itself, e.g.:A skip link does not need to be a landmark region. It should be a bare
<a>element.Changes
<div role="region" aria-label={...}>wrapper fromSkipToContentLinkrefdirectly onto the<a>element (renamedcontainerRef=>anchorRef, type updated toHTMLAnchorElement)Test Plan
<main>.Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs