Open
Conversation
…oom-zaxis-fix/issues/703) and also issue [fabiangreffrath#381](https://github.com/Paf2020/crispy-doom-zaxis-fix/issues/381) (not sure about that ot that one), although with minor overreach (All objects can be walked over/under now, might need to add custom heights or a option for custom heights for objects without realistic default heights.) I think it's all properly guarded with if (critical->overunder)."
Owner
|
Thank you very much for this! However, this isn't in a state that can be merged as is. Could you please factor this out into smaller chunks and commit them one after another? For example, I realize that So, could you please build this back so that it only fixes the underlying issue and nothing more and then we approach the next goal (i.e. extending the over/under ability to any monster) in a follow up PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied text from the commit log: "Fixed issue #703 and also issue #381 (not sure about that one, might have been a different problem), although with minor overreach (All objects can be walked over/under now, might need to add custom heights or a option for custom heights for objects without realistic default heights.) I think it's all properly guarded with if (critical->overunder)."
I think the modified doomretro code for unblocking should still work - I didn't get to test it, but if it doesn't work, it should be fine reverted. I think I had some issues while testing it, which is why I changed it, but I don't exactly remember.
Anyway, I tested the issue #703 with the same wad - it works now. A easier example is E3M8 - turn on IDKFA, IDDQD, go over to the spider mastermind, get it to move over to the ledge, turn on the overunder option, enable jump, jump on it when it starts firing, wait until you stop, type "TNTEM", it will die and you will fall immediately. I did some testing with cacodemons and it doesn't seem they have any issues with their floors being set either, so I think this is now working (aside from one minor issue).
The one issue I've seen so far:
I did do testing, but I'm not 100% confident that it's fully working beyond that.
You should be able to disable the overunder codes for obstacles if you want to only keep it for monsters - I'm not sure which one is preferred, but I figured I'd just make the pull request with the most permissive code.
My code is a bit messy, as I'm not too experienced with coding, but it does work.