Skip to content

Use relative symlinks for assets:install command#437

Open
emodric wants to merge 1 commit into
ezsystems:masterfrom
emodric:patch-4
Open

Use relative symlinks for assets:install command#437
emodric wants to merge 1 commit into
ezsystems:masterfrom
emodric:patch-4

Conversation

@emodric

@emodric emodric commented Jul 23, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@andrerom

andrerom commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

Or do we want to re-add the config from earlier branches?

"symfony-assets-install": "relative",

@emodric

emodric commented Jul 30, 2019

Copy link
Copy Markdown
Contributor Author

Does that still work?

If it does, it would be better, to prevent Symfony recipes overwriting the command in auto-scripts.

@emodric

emodric commented Jul 30, 2019

Copy link
Copy Markdown
Contributor Author

Tried it, it doesn't work.

@andrerom

Copy link
Copy Markdown
Contributor

What about us asking them to re-add support for that?

But that said, I guess it won't help once we move to full symfony flex over meta repo.

@emodric

emodric commented Jul 30, 2019

Copy link
Copy Markdown
Contributor Author

What about us asking them to re-add support for that?

They actually removed it before due to it not working on some setups: symfony/recipes#406

But that said, I guess it won't help once we move to full symfony flex over meta repo.

Not sure what you mean?

@emodric

emodric commented Jul 30, 2019

Copy link
Copy Markdown
Contributor Author

I'm not sure what would be the best course of action here. This patch has an effect of default version of assets:install being readded to auto-scripts as described in symfony/recipes#631. It would require symfony.lock to be present to prevent it from happening (hence my other PR)

@andrerom andrerom added the 3.x label Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants