add device pulling example#74
Open
Quadraplex-T3000 wants to merge 2 commits into
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
JackHowa
requested changes
May 13, 2026
Contributor
JackHowa
left a comment
There was a problem hiding this comment.
The script appears incomplete — device_list = [] is hardcoded empty so the core logic never runs. argparse is imported but never used (no ArgumentParser, no arguments defined, no parse_args() call), suggesting CLI input was intended but not implemented. The script needs a way to pass in the device list before it is usable as an example.
A few other things to clean up while you are at it:
import pdbleft in (debugger import, unused)via_siem_config_inventory = {}defined but never used- Bare
except:should beexcept Exception as e:to avoid swallowingKeyboardInterruptetc. - Module docstring references
poll_device_health.py— looks like a copy-paste from another script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.