fix(dbaas): send pg-migration-ignore-dbs value to API#839
Merged
Conversation
These are generic and useful for any test. I'd rather this be in an internal/testutils package, but pkg/testutils is used in the Terraform provider[1], so placed there for consistency. [1]: https://github.com/exoscale/terraform-provider-exoscale/tree/00698077587665e22c858d99499cb9a7b2567a8e/pkg/testutils
Previously the value of `--pg-migration-ignore-dbs` was being ignored, since the command checked for the value of `MysqlMigrationIgnoreDbs` instead of `PGMigrationIgnoreDbs`. Part of internal support ticket 1167395.
imiric
force-pushed
the
imiric/fix/1167395-dbaas-update-pg-ignore-dbs
branch
from
9045938 to
98eb406
Compare
natalie-o-perret
approved these changes
Jun 5, 2026
Member
Author
|
I'm not sure what's the deal with that E2E test failure. It passed in a previous run. 😕 I'll run it once more, but it seems unrelated. Ah: Yeah, unrelated. Merging. |
Contributor
Yea that's the sadly all too "usual" nlb exhaustion on UAT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously the value of
--pg-migration-ignore-dbswas being ignored, since the command checked for the value ofMysqlMigrationIgnoreDbsinstead ofPGMigrationIgnoreDbs.I also took the opportunity to DRY some of our test helpers and move them into a common
testutilspackage.Part of internal support ticket 1167395.
Checklist
(For exoscale contributors)
Testing
Added a new unit test that confirms the value is correctly sent to the server.