Improved Call screen, rewritten CallManager with 4 calll states #1334
7 new alerts
New alerts in code changed by this pull request
- 7 warnings
See annotations below for details.
Annotations
Check warning on line 175 in atox/src/main/kotlin/ui/call/CallFragment.kt
github-advanced-security / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
This expression contains a magic number. Consider defining it to a well named constant.
Check warning on line 37 in atox/src/main/kotlin/ui/call/CallViewModel.kt
github-advanced-security / detekt
Variable names should follow the naming convention set in the projects configuration.
Variable names should match the pattern: [a-z][A-Za-z0-9]*
Check warning on line 37 in atox/src/main/kotlin/ui/call/CallViewModel.kt
github-advanced-security / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
This expression contains a magic number. Consider defining it to a well named constant.
Check warning on line 83 in atox/src/main/kotlin/ui/call/CallViewModel.kt
github-advanced-security / detekt
Function parameter is unused and should be removed.
Function parameter `nanoseconds` is unused.
Check warning on line 89 in atox/src/main/kotlin/ui/call/CallViewModel.kt
github-advanced-security / detekt
Implicit default locale used for string processing. Consider using explicit locale.
String.format("%02d:%02d", minutes, seconds) uses implicitly default locale for string formatting.
Check warning on line 96 in atox/src/main/kotlin/ui/call/CallViewModel.kt
github-advanced-security / detekt
Implicit default locale used for string processing. Consider using explicit locale.
String.format("%01d:%02d:%02d", hours, minutes, seconds) uses implicitly default locale for string formatting.
Check warning on line 108 in atox/src/main/kotlin/ui/call/CallViewModel.kt
github-advanced-security / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
This expression contains a magic number. Consider defining it to a well named constant.